[MonoDevelop] Removing SourceEditor{View, Buffer} dependancy from CompletionListWindow.

[Lluis Sanchez]

The patch looks good to me.

Thanks!
Lluis.

El dt 19 de 07 del 2005 a les 18:31 -0700, en/na Peter Johanson va
escriure:
> On Tue, Jul 19, 2005 at 10:52:02AM +0200, Lluis Sanchez wrote:
> > Hi,
> > 
> > The patch looks like a good start. Here are some comments:
> > 
> >       * prepareCompletionDetails -> PrepareCompletionDetails
> > 
> >       * You should avoid using a property like ICompletionWidget.Text.
> >         Loading the entire file text in memory is a bad practice. I know
> >         we are doing it in other places but it shouldn't be done. In
> >         most of cases you can use methods such as for example: string
> >         GetText (int startOffset, int endOffset).
> > 
> >       * Methods in TextUtilities should take a ICompletionWidget as
> >         parameter and use its methods to get the text it needs. The same
> >         for ICompletionDataProvider, TemplateCompletionDataProvider and
> >         CommentCompletionDataProvider.
> > 
> >       * Please give more meaningful names to ICompletionWidget
> >         properties (what does X and Y refer to?). 
> > 
> >       * ICompletionData.InsertAction should also take a
> >         ICompletionWidget as parameter. 
> > 
> >       * CompletionWindow.cs is obsolete, it can be removed. 
> > 
> 
> Ok, attached are two new versions of the patches implementing the points
> above. Further thoughts?
> 
> -pete
> 
> 
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-list