[MonoDevelop] log4net logging patch

Sat, 2 Apr 2005 09:12:06 +0200

No, because you call IsDebugEnabled on a logger. And to get a logger you 
need a stack walk...

Jarek
----- Original Message ----- 
From: "Christian J. Hergert" <christian.hergert@team.mosaix.net>
To: <jaak@zd.com.pl>
Sent: Saturday, April 02, 2005 7:37 AM
Subject: Re: Re: [MonoDevelop] log4net logging patch

> It actually wraps the the log4net engine which has a property set. It 
> shouldnt be much overhead.
>
> Chris
> -----Original Message-----
> From: "Jaroslaw Kowalski" <jaak@zd.com.pl>
> To: "Christian Hergert" <christian.hergert@gmail.com>
> Date: Sat, 2 Apr 2005 06:20:00 +0200
> Subject: Re: [MonoDevelop] log4net logging patch
>
> Yes, but as far as I understand it. IsDebugEnabled also requires a stack
> trace...
>
> Jarek
> ----- Original Message ----- 
> From: "Christian Hergert" <christian.hergert@gmail.com>
> To: "Jaroslaw Kowalski" <jaak@zd.com.pl>
> Sent: Saturday, April 02, 2005 6:05 AM
> Subject: Re: [MonoDevelop] log4net logging patch
>
>
>>I agree the stack walk is an issue. I can change this to only grab the
>> stack information when IsDebugEnabled is set. That way we only slow
>> down in cases where we want to.
>>
>> ~ chris
>>
>> On Apr 1, 2005 7:56 PM, Jaroslaw Kowalski <jaak@zd.com.pl> wrote:
>>> Hi!
>>>
>>> I've looked into the patch and I'm worried about the performance. You
>>> seem
>>> to be using new StackTrace on each and every method just to get the
>>> calling
>>> type name. This is going to be huge performance hit, especially in a
>>> tight
>>> loop.
>>>
>>> You may also want to look at NLog (http://nlog.sourceforge.net). It is 
>>> an
>>> easy-to-use log4net alternative that directly supports formatted 
>>> logging.
>>> Mono is supported and the library provides out-of-the box binary
>>> compatibility for many platforms (no recompile required!). And it's
>>> pretty
>>> fast (it can filter more than 100 million logs per second on my Centrino
>>> 1.6
>>> laptop).
>>>
>>> NLog is BSD-licensed.
>>>
>>> Jarek
>>>
>>> http://blog.jkowalski.net/ - my blog about NLog, Sooda and other things.
>>>
>>> ----- Original Message -----
>>> From: "John Luke" <john.luke@gmail.com>
>>> To: "Christian Hergert" <christian.hergert@gmail.com>
>>> Cc: <monodevelop-list@lists.ximian.com>
>>> Sent: Saturday, April 02, 2005 3:43 AM
>>> Subject: Re: [MonoDevelop] log4net logging patch
>>>
>>> > On Fri, 2005-04-01 at 16:29 -0800, Christian Hergert wrote:
>>> >> Attached is a diff patch for the logging service. It does not include
>>> >> the log4net dll, so if you want to use it, put log4net.dll in
>>> >> contrib/. You can get the log4net build from logging.apache.org.
>>> >
>>> > Looks alright to me except for some quibbles (some not really specific
>>> > to your patch).
>>> >
>>> > We probably don't want to log/print translated messages
>>> >
>>> > Since you have the *Format ones maybe go ahead and use them even 
>>> > though
>>> > the previous WriteLines didn't
>>> >
>>> > in Core/src/MonoDevelop.Base/Makefile.am:
>>> > -assembly_DATA = $(ASSEMBLY) $(CONFIG)
>>> > +assembly_DATA = $(ASSEMBLY) $(CONFIG)
>>> > $(top_builddir)/contrib/log4net.dll
>>> >
>>> > probably should be moved into contrib/Makefile.am
>>> > Which makes me ask why don't we import the source and build it?
>>> > It is not real large is it?
>>> >
>>> > typo in Core/src/MonoDevelop.Startup/Makefile.am:
>>> > the app.config should get installed
>>> > +assembly_DATA = $(DLL) $
>>> >
>>> > last make sure we are meeting their license correctly please (part 4 
>>> > in
>>> > particular). I think a COPYING.log4net and a blurb in the README 
>>> > should
>>> > do.
>>> >
>>> >
>>> > _______________________________________________
>>> > Monodevelop-list mailing list
>>> > Monodevelop-list@lists.ximian.com
>>> > http://lists.ximian.com/mailman/listinfo/monodevelop-list
>>> >
>>>
>>>
>>
>>
>> -- 
>> Christian Hergert
>> Mosaix Communications, Inc.
>> Software Engineer
>> C: 253 906 2115
>>
>
>
>
> Christian J. Hergert
> 