[MonoDevelop] log4net logging patch

John Luke john.luke@gmail.com
Fri, 01 Apr 2005 20:43:05 -0500

On Fri, 2005-04-01 at 16:29 -0800, Christian Hergert wrote:
> Attached is a diff patch for the logging service. It does not include
> the log4net dll, so if you want to use it, put log4net.dll in
> contrib/. You can get the log4net build from logging.apache.org.

Looks alright to me except for some quibbles (some not really specific
to your patch).

We probably don't want to log/print translated messages

Since you have the *Format ones maybe go ahead and use them even though
the previous WriteLines didn't

in Core/src/MonoDevelop.Base/Makefile.am:
-assembly_DATA = $(ASSEMBLY) $(CONFIG)
+assembly_DATA = $(ASSEMBLY) $(CONFIG)

probably should be moved into contrib/Makefile.am
Which makes me ask why don't we import the source and build it?
It is not real large is it?

typo in Core/src/MonoDevelop.Startup/Makefile.am:
the app.config should get installed
+assembly_DATA = $(DLL) $

last make sure we are meeting their license correctly please (part 4 in
particular). I think a COPYING.log4net and a blurb in the README should