[Monodevelop-devel] Text Editor API GetCharAt

[Mike Krüger]

Hi

To be fair it's something I've borrowed from Roslyn.

Regards
Mike
> Hi Mike,
>
> I like the API change you are suggesting.
>
> Jeff
>
>
>
> On Fri, Jun 20, 2014 at 1:16 PM, Mike Krüger <mkrueger at xamarin.com 
> <mailto:mkrueger at xamarin.com>> wrote:
>
>
>     Hi
>
>     I'm currently reviewing the text editor API. We've a method called:
>
>     public char GetCharAt (int < span class="n" style="box-sizing:
>     border-box; color: rgb(51, 51, 51);">offset)
>
>
>     And atm I think about replacing it with :
>
>     public  char  this[int  offset]  
>
>     Maybe even add a setter to that - then the editor may feel a bit
>     more like a string from a certain PoV.
>     The question is: Is that a good or bad choice - how are you
>     feeling about it ?
>
>     The text editor has 3 layers: Text, Document and Editor - each
>     layer adds something on top of the text. The GetCharAt is a
>     functionality from the Text. On this level there is just text. I
>     think the indexer makes sense there. But how about the upper
>     layers? At Document level the editor becomes a collection of lines
>     as well.
>
>     I would love to hear some opinions. (About the speed: In this is a
>     very lightweight operation - in our current Implementation it's
>     done in O(1) in the worst case I can imagine that it becomes an
>     O(log N) one).
>
>     Regards
>     Mike
>
>
>
>     _______________________________________________
>     Monodevelop-devel-list mailing list
>     Monodevelop-devel-list at lists.ximian.com
>     <mailto:Monodevelop-devel-list at lists.ximian.com>
>     http://lists.ximian.com/mailman/listinfo/monodevelop-devel-list
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/monodevelop-devel-list/attachments/20140620/7d32d021/attachment-0001.html>