[Mono-winforms-list] [PATCH] For MouseClick Event in SWF

[Petit Eric]

Here they are.
That's folks !

2009/10/28 Carlos Alberto Cortez <calberto.cortez at gmail.com>

> Patches must be separated logic-wise. In this case, you should send me:
>
> a) a patch for the mouse click thing
> b) a patch for the masked textbox thing (yet to be reviewed)
>
> Again: this is the way all the contributors follow: from the one sending a
> one line fix, to the ones implementing new runtime features.
>
>
> 2009/10/28 Petit Eric <surfzoid at gmail.com>
>
>> Finally, here it an all in one patch, review from your comments, for the
>> MouseClick Event and the standard context menu for the MaskedTextBox.
>>
>> 2009/10/28 Petit Eric <surfzoid at gmail.com>
>>
>> oki , weired, but i will try to do it;
>>> Effort are duplicate, your comment are really nice and right, i need to
>>> took them for next patch, but most of them are to delete some extra data in
>>> the patch, after you will review a second time etc :-)
>>>
>>> 2009/10/28 Carlos Alberto Cortez <calberto.cortez at gmail.com>
>>>
>>> No dude, you need to do it directly you. That's the usual process all the
>>>> contributors do: they send a patch, then the maintainer suggests some
>>>> changes, then the contributor applies those changes.
>>>>
>>>>
>>>> Carlos.
>>>>
>>>> 2009/10/27 Petit Eric <surfzoid at gmail.com>
>>>>
>>>>> Hum, could you directly modify it ! ?
>>>>>
>>>>>
>>>>>
>>>>> 2009/10/27 Carlos Alberto Cortez <calberto.cortez at gmail.com>
>>>>>
>>>>>> Comments below:
>>>>>>
>>>>>> -               protected override void OnMouseUp (MouseEventArgs
>>>>>> mevent)
>>>>>> -               {
>>>>>> -                       base.OnMouseUp (mevent);
>>>>>> -               }
>>>>>> +        protected override void OnMouseUp(MouseEventArgs mevent)
>>>>>> +        {
>>>>>> +            base.OnMouseUp(mevent);
>>>>>> +        }
>>>>>>
>>>>>> +        protected override void OnMouseClick(MouseEventArgs mevent)
>>>>>> +        {
>>>>>> +            base.OnMouseClick(mevent);
>>>>>> +        }
>>>>>> +
>>>>>>
>>>>>> Be careful to *not* send changes including style modifications.
>>>>>>
>>>>>> +        protected override void OnMouseClick(MouseEventArgs mevent)
>>>>>> +        {
>>>>>> +            if ((mevent.Button & MouseButtons.Left) != 0)
>>>>>> +            {
>>>>>> +                is_pressed = true;
>>>>>> +                Invalidate();
>>>>>> +            }
>>>>>> +
>>>>>> +            base.OnMouseClick(mevent);
>>>>>> +        }
>>>>>> +
>>>>>>
>>>>>> In .Net ButtonBase is not overriding this method, so we can't do that.
>>>>>> Moreover, we don't need to do this.
>>>>>>
>>>>>> -                                       if (!ValidationFailed)
>>>>>> -                                               OnClick
>>>>>> (EventArgs.Empty);
>>>>>> +                    if (!ValidationFailed)
>>>>>> +                    {
>>>>>> +                        OnClick(EventArgs.Empty);
>>>>>> +                        OnMouseClick(mevent);
>>>>>> +                    }
>>>>>>
>>>>>> This is fine, and this is the only bit we need to fix the issue. Just
>>>>>> follow the coding guidelines: http://www.mono-project.com/Guidelines
>>>>>>
>>>>>> Re-send me the patch when it's done ;-)
>>>>>>
>>>>>> Carlos.
>>>>>>
>>>>>>
>>>>>> 2009/10/27 Carlos Alberto Cortez <calberto.cortez at gmail.com>
>>>>>>
>>>>>>> Hey,
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> I will review the patch later, but there's no need to send the patch
>>>>>>> to the mono develop list, since the change is related to windows.forms.
>>>>>>> Also, the mono-patches list is used to receive/catch the changes in svn.
>>>>>>> Next time send the patch to the winforms list, please.
>>>>>>>
>>>>>>> Carlos.
>>>>>>>
>>>>>>> 2009/10/27 Petit Eric <surfzoid at gmail.com>
>>>>>>>
>>>>>>> Hi
>>>>>>>> Mouse Click Event was missing in SWF implementation, here it is a
>>>>>>>> patch to fix that [?]
>>>>>>>> it is released under MIT/X11 or what ever you want.
>>>>>>>> Carlos, if you apply the patch, could you think about my "coding for
>>>>>>>> fun" and add my nickname in the log ?[?]
>>>>>>>>  --
>>>>>>>> Cordially.
>>>>>>>>
>>>>>>>> Small Eric Quotations of the days:
>>>>>>>> ---------------------------------------------------------------------------
>>>>>>>>
>>>>>>>> I have no special talents. I am only passionately curious
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Cordially.
>>>>>
>>>>> Small Eric Quotations of the days:
>>>>> ---------------------------------------------------------------------------
>>>>>
>>>>> I have no special talents. I am only passionately curious
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Cordially.
>>>
>>> Small Eric Quotations of the days:
>>> ---------------------------------------------------------------------------
>>>
>>> I have no special talents. I am only passionately curious
>>>
>>
>>
>>
>> --
>> Cordially.
>>
>> Small Eric Quotations of the days:
>> ---------------------------------------------------------------------------
>>
>> I have no special talents. I am only passionately curious
>> Sent from Paris, France
>
>
>


-- 
Cordially.

Small Eric Quotations of the days:
---------------------------------------------------------------------------
I have no special talents. I am only passionately curious
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-winforms-list/attachments/20091028/f2659243/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/png
Size: 628 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-winforms-list/attachments/20091028/f2659243/attachment.png 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/gif
Size: 96 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-winforms-list/attachments/20091028/f2659243/attachment.gif 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: masked textbox thing.patch
Type: application/octet-stream
Size: 3030 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-winforms-list/attachments/20091028/f2659243/attachment.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mouse click thing.patch
Type: application/octet-stream
Size: 761 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-winforms-list/attachments/20091028/f2659243/attachment-0001.obj