[Mono-winforms-list] GetThemePartSize parameter type patch

[Andy Hume]

George Giolfan wrote:
> 
> I cannot actually test this, but based on the documentation it is wrong on
> 64 bit versions.
> 

FxCop lists 24 more:

UXTheme.DrawThemeEdge
UXTheme.DrawThemeParentBackground
UXTheme.GetThemeTextExtent
Win32DnD.Win32DoDragDrop
XplatUIWin32.Win32CreateHatchBrush
XplatUIWin32.Win32CreateHatchBrush
XplatUIWin32.Win32CreatePen
XplatUIWin32.Win32CreatePen
XplatUIWin32.Win32EnableWindow
XplatUIWin32.Win32GetClientRect
XplatUIWin32.Win32GetWindowRect
XplatUIWin32.Win32GetWindowRgn
XplatUIWin32.Win32GlobalAlloc
XplatUIWin32.Win32GlobalSize
XplatUIWin32.Win32GlobalUnlock
XplatUIWin32.Win32LoadCursor
XplatUIWin32.Win32MessageBox, 
XplatUIWin32.Win32PlaySound
XplatUIWin32.Win32RegisterClass
XplatUIWin32.Win32ReleaseCapture
XplatUIWin32.Win32ReleaseDC
XplatUIWin32.Win32SetLayeredWindowAttributes
XplatUIWin32.Win32ShowCursor
XplatUIWin32.Win32UpdateWindow

The first says:
"As it is declared in your code, parameter 'pRect' 
of PInvoke UXTheme.DrawThemeEdge(IntPtr, IntPtr, Int32, 
Int32, RECT&, UInt32, UInt32, Int32):Int32 will be 
4 bytes wide on 64-bit platforms. This is not correct, 
as the actual native declaration of this API indicates 
it should be 8 bytes wide on 64-bit platforms. Consult 
the MSDN Platform SDK documentation for help determining 
what data type should be used instead of 'System.Int32'."

There are various types of report within the others.  The FxCop rule is
described at http://msdn.microsoft.com/en-us/library/ms182284(VS.80).aspx


If they turn out to useful there are also twenty-four reports for other
assemblies that we should have someone look at.

Of course that's only the Win32 ones, as it hasn't the information for any
other platform calls.  I'm not sure what it uses as an information source…
-- 
View this message in context: http://www.nabble.com/GetThemePartSize-parameter-type-patch-tp17715630p17773170.html
Sent from the Mono - WinForms mailing list archive at Nabble.com.