[Mono-winforms-list] Fwd: [PATCH] AutoSize fixes for bug 355408 - Please Review

Jonathan Pobst monkey at jpobst.com
Wed Jul 2 11:48:38 EDT 2008


Hey Ivan,

Your patch leaves two blocks of unreachable code.

Also, layout is extremely tricky and easily testable, so EVERY change to 
default/table/flow layout MUST have a test case.  See TableLayoutTest.cs.

Other than that, it looks ok.

Jonathan


Ivan N. Zlatev wrote:
> Hey,
> 
> Attached patch fixes bug 355408.  We have to take in account controls
> and their size regardless of their dock/anchor state when calculating
> row/column sizes.
> 
> If there are no objections I will commit.
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Mono-winforms-list maillist  -  Mono-winforms-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-winforms-list



More information about the Mono-winforms-list mailing list