[Mono-winforms-list] patch for 80020, comments?

[Rolf Bjarne Kvinge]

> This seems to fix everything in ControlHandleTest on X11, not sure
> about windows.  It also fixes things "the right way" wrt WM_CREATE and
> WM_SHOWWINDOW, which we now generate on X11.

If I open FormsTest and select the TextBox2 tab, I get this (didn't see any problems with the textbox though):

rolf at linux:/mono/head/winforms/formstest> mono FormsTest.exe
X11 Error encountered:
  Error: BadMatch (invalid parameter attributes)
  Request:     12 (X_ConfigureWindow)
  Resource ID: 0x680006A
  Serial:      17653
  Hwnd:        Hwnd, Mapped:True ClientWindow:0x680006B, WholeWindow:0x680006A, Parent:[Hwnd, Mapped:True ClientWindow:0x68011A8, WholeWindow:0x68011A7, Parent:[Hwnd, Mapped:True ClientWindow:0x680011C, WholeWindow:0x680011B, Parent:[Hwnd, Mapped:True ClientWindow:0x680010A, WholeWindow:0x6800109, Parent:[Hwnd, Mapped:True ClientWindow:0x6800108, WholeWindow:0x6800107, Parent:[<null>]]]]]
  Control:     System.Windows.Forms.ImplicitVScrollBar, Minimum: 0, Maximum: 296, Value: 0
   at System.Windows.Forms.XplatUIX11.HandleError ()
   at System.Windows.Forms.XplatUIX11.HandleError ()
   at System.Drawing.GDIPlus.GdipCreateFromXDrawable_linux ()
   at System.Drawing.GDIPlus.GdipCreateFromXDrawable_linux ()
   at System.Drawing.Graphics.FromXDrawable ()
   at System.Drawing.Graphics.FromHwnd ()
   at System.Windows.Forms.Control.CreateGraphics ()
   at System.Windows.Forms.TextBoxBase.CreateGraphicsInternal ()
   at System.Windows.Forms.Document.owner_VisibleChanged ()
   at System.MulticastDelegate.invoke_void_object_EventArgs ()
   at System.Windows.Forms.Control.OnVisibleChanged ()
   at System.Windows.Forms.Control.OnParentVisibleChanged ()
   at System.Windows.Forms.Control.OnVisibleChanged ()
   at System.Windows.Forms.ScrollableControl.OnVisibleChanged ()
   at System.Windows.Forms.Control.SetVisibleCore ()
   at System.Windows.Forms.Control.set_Visible ()
   at System.Windows.Forms.TabPage.SetVisible ()
   at System.Windows.Forms.TabControl.set_SelectedIndex ()
   at System.Windows.Forms.TabControl.MouseDownHandler ()
   at System.MulticastDelegate.invoke_void_object_MouseEventArgs ()
   at System.Windows.Forms.Control.OnMouseDown ()
   at System.Windows.Forms.Control.WndProc ()
   at System.Windows.Forms.TabControl.WndProc ()
   at System.Windows.Forms.Control+ControlNativeWindow.WndProc ()
   at System.Windows.Forms.NativeWindow.WndProc ()
   at System.Windows.Forms.XplatUIX11.DispatchMessage ()
   at System.Windows.Forms.XplatUI.DispatchMessage ()
   at System.Windows.Forms.Application.RunLoop ()
   at System.Windows.Forms.Application.Run ()
   at FormsTest.FormsTest.Main ()
> 
> It doesn't fix the test in FormTest.cs that was put there for 80020.
> MDI children handles are still being created too early, but my brain
> isn't capable at this point of fixing it, so I figured I'd send what I
> had and see how people feel about the changes.


I'll have a look at this to see how it can be done.

Rolf