[Mono-winforms-list] RE RE: TabControl.cs Patch

[berni x]

Hi

the behavor of MS is to throw a argumentnullException if the referenz of TabPage is null.
If the TabPage is not found or it is the last tab a
Argumentoutofrangeexception is thrown

according to MSDN: http://msdn2.microsoft.com/en-us/library/xck4eb8y(VS.80).aspx

i have patched the thing,
sry for sending uncomplete Diff files, im just starting as developer :D 

hope this file meets the exceptions

yours berni
> -----Ursprüngliche Nachricht-----
> Von: "Gert Driesen" <gert.driesen at telenet.be>
> Gesendet: 29.04.07 13:00:41
> An:  <mono-winforms-list at lists.ximian.com>
> Betreff: RE: [Mono-winforms-list] TabControl.cs Patch


> 
> Berni,
> 
> In DeselectTab (int) you should take into account that the deselected tab
> might be the last or even the only tab, and verify the behaviour of MS.
> 
> In DeselectTab (TabPage) and SelectTab (TagPage) you should take into
> account that the specified tab was never added to the TabControl, and verify
> the behaviour of MS.
> 
> Do the exceptions you throw in SelectTab (string) and DeselectTab (string)
> match those thrown by MS ?
> 
> Can you also add unit tests for these methods ?
> 
> Gert
> 
> -----Original Message-----
> From: mono-winforms-list-bounces at lists.ximian.com
> [mailto:mono-winforms-list-bounces at lists.ximian.com] On Behalf Of berni x
> Sent: zondag 29 april 2007 12:52
> To: mono-winforms-list at lists.ximian.com
> Subject: [Mono-winforms-list] TabControl.cs Patch
> 
> I have implemented 2 overloads of SelectTab ( with TabPage and String) And i
> have implementeet 3 overloads of DeselectTab
> 
> Hope this diffs is going to be commited
> 
> berni
> _______________________________________________________________
> SMS schreiben mit WEB.DE FreeMail - einfach, schnell und kostenguenstig.
> Jetzt gleich testen! http://f.web.de/?mc=021192
> 
> 
> 


_______________________________________________________________
SMS schreiben mit WEB.DE FreeMail - einfach, schnell und
kostenguenstig. Jetzt gleich testen! http://f.web.de/?mc=021192

-------------- next part --------------
A non-text attachment was scrubbed...
Name: TabControlDiff
Type: application/octet-stream
Size: 1263 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-winforms-list/attachments/20070429/94872c09/attachment-0001.obj