[Mono-winforms-list] [PATCH] Theme.DefaultFont

[Jackson Harper]

On Fri, 2006-12-29 at 10:07 -0800, Chris Toshok wrote:
> I don't really know if there's any historical significance to using 8
> instead of 8.25.  I can't imagine there is.  anyone else know?


 2006-05-22  Peter Dennis Bartok  <pbartok at novell.com> 

* ThemeWin32Classic.cs: Changed DefaultFont emSize from 8.25 to 8
  to get the same width/height (5/13) on X11 as the default font has on
  win32. This means that our DefaultFont emSize is smaller than the 
  the MS SWF equivalent (even thought the width/height stays the same)


> The patch looks good to me, aside from one minor change - there's no
> need to keep the readonly modifier on default_font if it's private.
> 
> Please, commit.  Thanks much.
> 
> Chris
> 
> On Fri, 2006-12-29 at 14:11 +0100, Gert Driesen wrote:
> > Hi,
> > 
> > The attached patch makes a small change to Theme (and derived classes)
> > to make it more compatible with MS (see included unit tests).
> > 
> > On both the 1.0 and 2.0 profile, Theme.DefaultFont is now MS Sans Sarif
> > 8.25 (instead of 8). This matches Control.Font and
> > SystemFonts.DefaultFont on MS.
> > 
> > On the 2.0 profile, Theme.DefaultFont is initialized with
> > SystemFonts.DefaultFont.
> > 
> > I modified the accessibility of the default_font field to private, since
> > Theme.DefaultFont is virtual anyway.
> > 
> > Let me know if it's ok to commit.
> > 
> > Gert
> > _______________________________________________
> > Mono-winforms-list maillist  -  Mono-winforms-list at lists.ximian.com
> > http://lists.ximian.com/mailman/listinfo/mono-winforms-list
> 
> _______________________________________________
> Mono-winforms-list maillist  -  Mono-winforms-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-winforms-list