[Mono-winforms-list] AutoComplete properties patch for Text- and Combobox

Daniel Nauck dna at informatik.uni-kiel.de
Wed Dec 20 18:46:33 EST 2006


attached is the new version.

I also implemented "Locale.GetText (string msg, params object [] args)"
for MWF.

Please review.


Miguel de Icaza schrieb:
> ello,
>> Any suggestions?
> Instead of using String.Format for the calls that will throw a
> user-visible error, use Locale.GetText (it takes the same arguments).
> When we do localization, this will reduce the work we do at that time.
> In general, I do not like Enum.IsDefined because it boxes the value on
> every call.  I would rather compare to upper/lower ranges which is
> faster (and besides, in Mono, we are guilty of not really doing Enum
> parameter checks in a number of places, which one day we might want to
> do).  
> If this was a common pattern, I wonder if it would be worth having the
> compiler inline Enum.IsDefined to avoid the boxing?   Worth considering.
> Miguel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: AutoCompletion.patch
Type: text/x-patch
Size: 10847 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-winforms-list/attachments/20061221/3fb502bf/attachment.bin 

More information about the Mono-winforms-list mailing list