[Mono-winforms-list] AutoComplete properties patch for Text- and Combobox
Miguel de Icaza
miguel at ximian.com
Wed Dec 20 14:38:47 EST 2006
ello,
> Any suggestions?
Instead of using String.Format for the calls that will throw a
user-visible error, use Locale.GetText (it takes the same arguments).
When we do localization, this will reduce the work we do at that time.
In general, I do not like Enum.IsDefined because it boxes the value on
every call. I would rather compare to upper/lower ranges which is
faster (and besides, in Mono, we are guilty of not really doing Enum
parameter checks in a number of places, which one day we might want to
do).
If this was a common pattern, I wonder if it would be worth having the
compiler inline Enum.IsDefined to avoid the boxing? Worth considering.
Miguel
More information about the Mono-winforms-list
mailing list