[Mono-winforms-list] ButtonBase.AutoSize Implementation

Miguel de Icaza miguel at ximian.com
Sun Dec 17 14:12:39 EST 2006


> thanks for the hint I've corrected the patch. It resizes now if the image, 
> font or text has been changed. This should cover all cases, or am I missing 
> something?

My code review comments:

Only a few comments, you code should follow the Mono naming conventions
for fields, so the field 'autoSize' should become "auto_size".

You do not need to use "this.Autosize" or "this.AutoCalculateNewSize",
you can remove the "this" from that bit (it happens in a bunch of other
places as well).

There are two magic constants in there, that am confused about: 35 and
15.   What are those for, and why are they needed?  Shouldnt those be
computed based on some font metric?


More information about the Mono-winforms-list mailing list