[Mono-winforms-list] libgdiplus/System.Drawing patch: nativesupport for indexed Bitmaps

Jonathan Gilbert 2a5gjx302@sneakemail.com
Mon, 07 Mar 2005 12:47:57 -0500

At 05:20 PM 07/03/2005 +0100, Jordi Mas wrote:
>El dl 07 de 03 del 2005 a les 00:41 -0500, en/na Miguel de Icaza va
>> Jordi, Peter, do you have any objections on getting this into the tree?
>> In any case, the code looks very solid, I would like to offer you an SVN
>> account as well.
>Good work Johnathan!
>One small thing. At bitmap.c, line number 425, the following function
>+	if (!gdip_is_an_indexed_pixelformat) {
>does not have the parameter need for the call, that looks like it has to
>be (srcData->PixelFormat)
>It looks fine to me also. A part of that I ran some regression testings
>and it passes them. 

Thanks for sniffing that out. I guess I'm losing my edge after all this C#
programming where that mistake would be caught by the compiler ;-)

Did you try the winforms/lockbits test case I included? And the other test
that I was recommended to work with was winforms/endian.

Jonathan Gilbert