[Mono-winforms-list] libgdiplus/System.Drawing patch: native support for indexed Bitmaps

Miguel de Icaza miguel@ximian.com
Mon, 07 Mar 2005 00:41:48 -0500


> Please find attached the following files:
> * libgdiplus.diff (patch -p0 in ./libgdiplus)
> * System.Drawing.diff (patch -p0 in ./mcs/class/System.Drawing)
> * lockbits.tgz (tar zvfx in ./)

>From my quick review of the code, this looks great.   

The has_next and stream processing routines seem to only be used in one
routine, so am left wondering if it might not be best to have those as
static functions so the compiler could inline some of it.

What is the performance impact on applications after this change?

Jordi, Peter, do you have any objections on getting this into the tree?

In any case, the code looks very solid, I would like to offer you an SVN
account as well.