[Mono-winforms-list] button implmentation

Alexandre Pigolkine pigolkine@gmx.de
Fri, 22 Aug 2003 18:25:46 +0200


This is a multi-part message in MIME format.

------=_NextPart_000_007C_01C368DA.CE460380
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Hello,

I modified ButtonBase and derived classes and committed the code to the =
CVS.
Looks like the changes don't break the tests.

Hopefully, the classes are more spec-conformant now.
Shall I send a compiled version of SWF dll to check that my changes are =
OK ?

Alexandre



  ----- Original Message -----=20
  From: Dennis Hayes=20
  To: mono-winforms-list@lists.ximian.com=20
  Sent: Sunday, August 10, 2003 7:45 AM
  Subject: [Mono-winforms-list] button implmentation


  Button.cs implments OnPaint.
  The spec says this should be in ButtonBase.cs.
  ButtonBase is just
  base.OnPaint (pevent)
  There is a lot of implmentation in button.cs

  *
  It looks like just replacing the ButtonBase OnPaint with the Button =
OnPaint, and removing the OnPaint from Button.cs would be the correct =
option.
  *
  Can someone do this and verify that is does not break any of the test?
  Thanks,
  Dennis



-------------------------------------------------------------------------=
-----
  Do you Yahoo!?
  Yahoo! SiteBuilder - Free, easy-to-use web site design software
------=_NextPart_000_007C_01C368DA.CE460380
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=3DContent-Type content=3D"text/html; =
charset=3Diso-8859-1">
<META content=3D"MSHTML 6.00.2800.1226" name=3DGENERATOR>
<STYLE></STYLE>
</HEAD>
<BODY bgColor=3D#ffffff>
<DIV><FONT face=3DArial size=3D2>Hello,</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT>&nbsp;</DIV>
<DIV><FONT face=3DArial size=3D2>I modified ButtonBase and derived =
classes and=20
committed the&nbsp;code to the CVS.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2>Looks like the changes don't break the=20
tests.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT>&nbsp;</DIV>
<DIV><FONT face=3DArial size=3D2>Hopefully, the classes&nbsp;are more=20
spec-conformant now.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2>Shall I send a compiled version of SWF =
dll&nbsp;to=20
check that my changes are OK ?</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT>&nbsp;</DIV>
<DIV><FONT face=3DArial size=3D2>Alexandre</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT>&nbsp;</DIV>
<DIV><FONT face=3DArial size=3D2></FONT>&nbsp;</DIV>
<DIV><FONT face=3DArial size=3D2></FONT>&nbsp;</DIV>
<BLOCKQUOTE=20
style=3D"PADDING-RIGHT: 0px; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; =
BORDER-LEFT: #000000 2px solid; MARGIN-RIGHT: 0px">
  <DIV style=3D"FONT: 10pt arial">----- Original Message ----- </DIV>
  <DIV=20
  style=3D"BACKGROUND: #e4e4e4; FONT: 10pt arial; font-color: =
black"><B>From:</B>=20
  <A title=3Ddenisraytek@yahoo.com =
href=3D"mailto:denisraytek@yahoo.com">Dennis=20
  Hayes</A> </DIV>
  <DIV style=3D"FONT: 10pt arial"><B>To:</B> <A=20
  title=3Dmono-winforms-list@lists.ximian.com=20
  =
href=3D"mailto:mono-winforms-list@lists.ximian.com">mono-winforms-list@li=
sts.ximian.com</A>=20
  </DIV>
  <DIV style=3D"FONT: 10pt arial"><B>Sent:</B> Sunday, August 10, 2003 =
7:45=20
  AM</DIV>
  <DIV style=3D"FONT: 10pt arial"><B>Subject:</B> [Mono-winforms-list] =
button=20
  implmentation</DIV>
  <DIV><BR></DIV>
  <DIV>Button.cs implments OnPaint.</DIV>
  <DIV>The spec says this should be in ButtonBase.cs.</DIV>
  <DIV>ButtonBase is just</DIV>
  <DIV><FONT color=3D#0000ff size=3D2>base</FONT><FONT size=3D2>.OnPaint =

  (pevent)</FONT></DIV>
  <DIV><FONT size=3D2>There is a lot of implmentation in =
button.cs</FONT></DIV>
  <DIV><FONT size=3D2></FONT>&nbsp;</DIV>
  <DIV><FONT size=3D2>*</FONT></DIV>
  <DIV><FONT size=3D2>It looks like just replacing the ButtonBase =
OnPaint with the=20
  Button OnPaint, and removing the OnPaint from Button.cs would be the =
correct=20
  option.</FONT></DIV>
  <DIV><FONT size=3D2>*</FONT></DIV>
  <DIV><FONT size=3D2>Can someone do this and verify that is does not =
break any of=20
  the test?</FONT></DIV>
  <DIV><FONT size=3D2>Thanks,</FONT></DIV>
  <DIV><FONT size=3D2>Dennis</FONT></DIV>
  <DIV><FONT size=3D2>&nbsp;</DIV></FONT>
  <P>
  <HR SIZE=3D1>
  Do you Yahoo!?<BR><A=20
  =
href=3D"http://us.rd.yahoo.com/evt=3D10469/*http://sitebuilder.yahoo.com"=
>Yahoo!=20
  SiteBuilder</A> - Free, easy-to-use web site design=20
software</BLOCKQUOTE></BODY></HTML>

------=_NextPart_000_007C_01C368DA.CE460380--