[mono-vb] FileSystem additions

Rob.Tillie@Student.tUL.EDU Rob.Tillie@Student.tUL.EDU
Mon, 21 Jun 2004 17:23:52 +0200


Comments inline.

> -----Original Message-----
> From: Jambunathan Jambunathan [mailto:kjambunathan@novell.com]
> Sent: Monday, June 21, 2004 4:58 PM
> To: Rob.Tillie@Student.tUL.EDU
> Cc: mono-vb@lists.ximian.com
> Subject: Re: [mono-vb] FileSystem additions
> 
> Rob
> 
> I will commit your patches tomorrow.
> 
> As you know I am working on the FileSystem
> as  well. We are trying to squeeze in as much as
> possible in to the 1.0 release so that more
> people get to use of our classes and test them
> for us.
> 
> In your previous patch for FileOPen I realised
> that you have replaced Hashmap with an Array.

I don't know exactly what you mean that I replaced, but it surely wasn't the
intention. I cannot remember changing anything to FileOpen.

> I was wondering  that if we could adopt "verbatim"
> mainsoft's implementation (as long as we have
> reviewed them to be making sense) then we could
> be really really churning out code much faster.
> (Btw, what do you guys say about this ? )

My idea exactly, because this implementation worked already, we should be
able to get FileSystem to work quickly.
Maybe we should coordinate it a bit to be sure we aren't doing the same
things...
BTW: Is it possible to create another patch for a file when the first one
hasn't been commited yet? Ideally, this last patch shouldn't include the
changes to the first file...

> It was with this intention that I had already
> checked in the basic classes (VBFile, BaseVBFile,
> InputVBFile, OutPutVBFile )

I'll convert RandomVBFile tonight...

Greetz,
-- Rob.
 
> Regards,
> Jambunathan K.
> 
> >>> <Rob.Tillie@Student.tUL.EDU> 06/19/04 02:45 AM >>>
> Hello,
> 
> Here's the implementation for FileLen and FileDateTime including unit
> tests.
> 
> To Jambunathan: I think you meant by 'self-containing' patches that I
> should
> sent them as small as possible, so this is a patch with only two
> methods.
> 
> Greetz,
> -- Rob.