[mono-vb] FileSystem patch and tests

Rob.Tillie@Student.tUL.EDU Rob.Tillie@Student.tUL.EDU
Thu, 17 Jun 2004 20:50:47 +0200


Comments inline.

> -----Original Message-----
> From: Jambunathan K [mailto:kjambunathan@novell.com]
> Sent: Thursday, June 17, 2004 3:57 PM
> To: Rob.Tillie@Student.tUL.EDU
> Cc: mono-vb@lists.ximian.com
> Subject: Re: [mono-vb] FileSystem patch and tests
> 
> Rob
> 
> I have committed your changes.
> 
> I have done some reformatting to FileSystem.cs so that it
> looks more pleasant. Kindly submit your further patches
> on the newly committed FileSystem.cs.

Thank you and will do.

> While submitting your next patch make sure that you adhere
> strictly to the coding guidelines for if, else and switch
> blocks and that you break up lines that have more than 134
> chars.

Yes, I'm trying to do this to my best knowledge. Please let me know when you
still see something that is not correct, because an example makes it a bit
easier :).

> Submit patches promptly as and when it becomes self-contained,
> so that manageability becomes easier.

Could you explain what you mean? Do you mean that I should send in patches
on a per-method basis?

> I haven't taken time off to critically review your patches,
> instinctively I can say that they are good.

I surely hope so :).

> By submitting patches and that too with consistency (inspite
> of two weeks being too short a time to arrive at a conclusion)
> you are gradually moving from a casual contributor to a serious
> mono-vb developer.
> 
> So some more patches & enhancements ;-) , you will be on your way to
> commit files directly to cvs.

Kewl, but let's first be sure I'm not making any formatting mistakes anymore
;).

> Regards,
> Jambunathan K.
> 
> 
> On Thu, 2004-06-17 at 10:49, Rob.Tillie@Student.tUL.EDU wrote:
> > Hello,
> >
> > This patch:
> > - replaces all leading spaces by tabs
> > - Reimplementation / check against MainSoft code / reformat of first 5
> > methods.
> > - adds unit tests for these methods.
> >
> > There remains one issue with these methods (affects 2 methods), but I
> > haven't figured out how this behaviour can be achieved exactly using
> normal
> > classes.
> >
> > Could someone plz commit?
> >
> > Greetz,
> > -- Rob.
> >