[mono-vb] FileSystem patch and tests

Jambunathan K kjambunathan@novell.com
Thu, 17 Jun 2004 19:26:38 +0530


I have committed your changes. 

I have done some reformatting to FileSystem.cs so that it 
looks more pleasant. Kindly submit your further patches 
on the newly committed FileSystem.cs.

While submitting your next patch make sure that you adhere 
strictly to the coding guidelines for if, else and switch 
blocks and that you break up lines that have more than 134

Submit patches promptly as and when it becomes self-contained, 
so that manageability becomes easier.

I haven't taken time off to critically review your patches,
instinctively I can say that they are good.

By submitting patches and that too with consistency (inspite 
of two weeks being too short a time to arrive at a conclusion)
you are gradually moving from a casual contributor to a serious 
mono-vb developer.

So some more patches & enhancements ;-) , you will be on your way to
commit files directly to cvs.

Jambunathan K.

On Thu, 2004-06-17 at 10:49, Rob.Tillie@Student.tUL.EDU wrote:
> Hello,
> This patch:
> - replaces all leading spaces by tabs
> - Reimplementation / check against MainSoft code / reformat of first 5
> methods.
> - adds unit tests for these methods.
> There remains one issue with these methods (affects 2 methods), but I
> haven't figured out how this behaviour can be achieved exactly using normal
> classes.
> Could someone plz commit? 
> Greetz,
> -- Rob.