[mono-vb] Implementation of Financial vb module

Andreas Nahr ClassDevelopment@A-SoftTech.com
Mon, 14 Jun 2004 00:44:54 +0200


I've just looked over your patch from the formatting point of view (some

-namespace Microsoft.VisualBasic
+namespace Microsoft.VisualBasic
+ <-- Line not needed
  sealed public class Financial {
@@ -19,32 +43,331 @@
   private Financial() {} <-- Extend to three lines

+  public static System.Double DDB (System.Double Cost, System.Double
Salvage, System.Double Life, System.Double Period,
[System.ComponentModel.DefaultValue(2)] System.Double Factor)
Should be:
+  public static double DDB (double Cost, double Salvage, double Life,
double Period, [Optional, DefaultValue (2)] double Factor)

throw new ArgumentException ("Argument 'Per' is not valid");
Should be:
throw new ArgumentException (Locale.GetText ("Invalid argument value."),

Also Tab is correct for spacing, however at various places tabs and spaces
are mixed, but only tabs should be used.


----- Original Message ----- 
From: <Rob.Tillie@Student.tUL.EDU>
To: <mono-vb@lists.ximian.com>
Sent: Saturday, June 12, 2004 1:17 PM
Subject: [mono-vb] Implementation of Financial vb module

> Hello all,
> Because of the complexity of FileSystem, I implemented Financial first
> together with unit tests, to get a feel for Mono and its formatting.
> It is largely copied from the MainSoft code, but I corrected a few
> implementation differences with MS.NET.
> Everything works like on MS.NET now.
> Because this is my first contribution, I would love to get some feedback
> what I have done wrong, especially concerning formatting.
> I used the tab character now for tabs, couldn't figure out if I was
> to use tab character or spaces.
> The formatting of FileSystem is pretty screwed up, could someone fix this
> could I post a formatting patch?
> Greetz,
> -- Rob.