[mono-vb] Implementation of Financial vb module

[Rob.Tillie@Student.tUL.EDU]

Hey Andreas, thanks for the comments.

Most of the things I were aware of, but they are already in the current stub
file. I read somewhere I wasn't supposed to reformat a class from someone
else, so I didn't touch it.
If it is ok, I'll reformat the whole class.

FileSystem is even in a worse shape, that's why I asked if it was ok to send
a reformatting patch first.

Greetz,
-- Rob.

> -----Original Message-----
> From: Andreas Nahr [mailto:ClassDevelopment@A-SoftTech.com]
> Sent: Monday, June 14, 2004 12:45 AM
> To: Rob.Tillie@Student.tUL.EDU; mono-vb@lists.ximian.com
> Subject: Re: [mono-vb] Implementation of Financial vb module
> 
> Hi,
> 
> I've just looked over your patch from the formatting point of view (some
> examples):
> 
> -namespace Microsoft.VisualBasic
> +namespace Microsoft.VisualBasic
> + <-- Line not needed
>  {
>   [StandardModule]
>   sealed public class Financial {
> @@ -19,32 +43,331 @@
>    private Financial() {} <-- Extend to three lines
> 
> +  public static System.Double DDB (System.Double Cost, System.Double
> Salvage, System.Double Life, System.Double Period,
> [System.Runtime.InteropServices.Optional]
> [System.ComponentModel.DefaultValue(2)] System.Double Factor)
> Should be:
> +  public static double DDB (double Cost, double Salvage, double Life,
> double Period, [Optional, DefaultValue (2)] double Factor)
> 
> throw new ArgumentException ("Argument 'Per' is not valid");
> Should be:
> throw new ArgumentException (Locale.GetText ("Invalid argument value."),
> "Per");
> 
> 
> Also Tab is correct for spacing, however at various places tabs and spaces
> are mixed, but only tabs should be used.
> 
> Andreas
> 
> ----- Original Message -----
> From: <Rob.Tillie@Student.tUL.EDU>
> To: <mono-vb@lists.ximian.com>
> Sent: Saturday, June 12, 2004 1:17 PM
> Subject: [mono-vb] Implementation of Financial vb module
> 
> 
> > Hello all,
> >
> > Because of the complexity of FileSystem, I implemented Financial first
> > together with unit tests, to get a feel for Mono and its formatting.
> >
> > It is largely copied from the MainSoft code, but I corrected a few
> > implementation differences with MS.NET.
> > Everything works like on MS.NET now.
> >
> > Because this is my first contribution, I would love to get some feedback
> on
> > what I have done wrong, especially concerning formatting.
> > I used the tab character now for tabs, couldn't figure out if I was
> supposed
> > to use tab character or spaces.
> >
> > The formatting of FileSystem is pretty screwed up, could someone fix
> this
> or
> > could I post a formatting patch?
> >
> > Greetz,
> > -- Rob.
> >
> >