[mono-vb] Patch for mbas for ByRef parameters from a DLL
Tue, 03 Aug 2004 03:43:12 -0600
> Also I was trying to get the tests going as they were before
> changing them and found that seem to fail compilation
> for me (e.g. LongTypeCharTestA.vb).
It apparently has nothing to do with your patch. The test fails
in my work area as well and my work area doesn't have your
> confused as to what the current state of tests was and how
> I could tell if I broke anything.
Under mcs/btests there is Readme that should provide some
information to go about. This is just a bare bone doc and we
are exploring ways of running/reporting of test cases
Currently there are number of test cases that break. One
approach that you could take is run a 'make all' under mcs/btests
and save the results.out file and then diff this against the new
results.out after yourchanges.
This is the approach we take. Painful but that's the way it is now.
> I can check in the code without the tests but thought I'd
> try and do both at once.
The right way to go.
So hope to see your patches and test cases soon.
Thanks a lot.
>>> "Bernie Solomon" <email@example.com> 8/2/2004 10:15:49 PM >>>
There were a couple of reasons I hadn't checked this in yet.
Being a little busy was one but there were some technical
In order to check in tests I need to modify the test setup
so that there are some separate DLLs built as well as individual
EXEs and I hadn't got round to do that yet (my original tests
I did by hand).
Also I was trying to get the tests going as they were before
changing them and found that seem to fail compilation
for me (e.g. LongTypeCharTestA.vb) and was then a little
confused as to what the current state of tests was and how
I could tell if I broke anything. Can you explain the setup or
is it my setup is broken and this should compile?
I can check in the code without the tests but thought I'd
try and do both at once.
----- Original Message -----
From: "Jambunathan Jambunathan" <firstname.lastname@example.org>
To: <email@example.com>; <firstname.lastname@example.org>
Sent: Monday, August 02, 2004 5:24 AM
Subject: Re: [mono-vb] Patch for mbas for ByRef parameters from a DLL
> We can integrate this patch in to cvs on behalf of you. But
> nevertheless if you could mail us your test cases we will be
> reassured that the patch really works.
> I am sure you have test samples that you used for testing the
> patch still lurking in your work area. Just grab it and mail across
> to us.
> Thanks once again for the patch.
> Jambunathan K.
> >>> "Bernie Solomon" <email@example.com> 7/28/2004 11:37:12 PM
> Here's a refinement which also allows use of enums declared in other
> the previous patch too).
> ----- Original Message -----
> From: "Solomon, Bernard" <firstname.lastname@example.org>
> To: <email@example.com>
> Sent: Wednesday, July 28, 2004 10:37 AM
> Subject: [mono-vb] Patch for mbas for ByRef parameters from a DLL
> [mono-vb] Patch for mbas for ByRef parameters from a DLLI attach a
> patch so
> that you can call methods in a referenced DLL that take
> reference parameters and things compile. To do this I have made
> ReflectionParameters return similar data to InternalParameters for
> parameters - and also use them when GetFullParameters doesn't return
> anything (presumably currently you can't call a method with optional
> parameters in a different DLL).
> Since I haven't done anything inside mbas before I may not have done
> this in
> the right way. But if it is OK I can commit this.
> Presumably a test case might be good but I am not quite sure where
> Bernie Solomon
> Mono-vb mailing list