[Mono-list] [Mono-dev] nunit test upgrading task force

[Charlie Poole]

Hi,

What you described below, plus the later comment about
adding TestFixture and test, should work OK. If there
are other types of asserts, you'll need to translate
them. I'm happy to take any questions (list or direct
email) of the nature "What's the best way ..."

Also, even though I called 2.4.8 the last 2.4 release,
I'd be glad to to a 2.4.9 for Mono if there should be
any problems that are easy to fix.

Charlie
 
PS: If you find (using NUnit 2.4.x) that anything is 
marked Obsolete, you can pretty much count that it's 
already gone in 2.5.


> -----Original Message-----
> From: mono-devel-list-bounces at lists.ximian.com 
> [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf 
> Of Atsushi Eno
> Sent: Monday, June 22, 2009 11:35 PM
> To: mono-devel-list at lists.ximian.com; Mono Mailing List
> Subject: [Mono-dev] nunit test upgrading task force
> 
> Hi,
> 
> I'm thinking if we can upgrade our nunit tests to eliminate 
> derivation from Assertion (such as eliminating AssertEquals), 
> to make our tests ready for future versions of NUnit.
> 
> The task is very easy: if there is a test class that looks like
> 
>      [TestFixture]
>      public class FooTest : Assertion
>      {
>          [Test]
>          public void FooBar ()
>          {
>              AssertEquals ("#1", str1, str2);
>          }
>      }
> 
> rewrite it like:
> 
>      [TestFixture]
>      public class FooTest
>      {
>          [Test]
>          public void FooBar ()
>          {
>              Assert.AreEqual (str1, str2, "#1");
>          }
>      }
> 
> I tried to count it by "grep AssertEquals", and there were 
> 8000 lines in corlib, 1000 lines in System, 1500 lines in 
> Sys.XML, and so on.
> 
> So, it is a simple but massive task that I cannot do it by myself.
> But if we can hack a volunteer team from here it would be possible.
> 
> If you can join the effort, you are welcome :)
> 
> * list of the files
> 
> I have made an easy list of such "old" test files on a spreadsheet:
> http://spreadsheets.google.com/pub?key=rkWl-ZQHJvcu6tkJOeFFg3A
> &output=html
> 
> * workflow
> 
> Basically, removing the base class (Assertion) will give lots 
> of errors. And when there is no more errors, then you are 
> done with it.
> 
> You might want to mark your ownership on the spreadsheet 
> before you actually start working on them. I'll release the 
> ownership if some of them are "locking".
> 
> If you have commit access, let's just check in. Otherwise, 
> post your changes. (attachment, monoport, etc.)
> 
> One sort of concern is that, if you are actively maintaining 
> some code files and making changes in such old test files, 
> please mark them as you don't want them changed.
> We don't have to do this conversion task perfectly right now. 
> (And of course you don't have to do upgrade task by yourself 
> because of marking them.)
> 
> * starting
> 
> If you are willing to join the task force, please drop me a 
> line and/or post to the list (here) :)
> 
> I'll share the spreadsheet so that you can edit the spreadsheet.
> If you don't have Google account, I'll update it instead 
> (with possible delay).
> 
> Atsushi Eno
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>