[Mono-list] [Mono-dev] Let's not compare exception messages in nunit tests

[Atsushi Eno]

Some tests may become successful when you set
Thread.CurrentThread.CurrentCulture to en-US. Some won't, unless
you set current langauge and/or region (you should not do that
programmatically even if possible, anyways).

Anyways it may solve only one aspect of the problems I stated earlier.

Atsushi Eno


Andrés G. Aragoneses wrote:
> Atsushi Eno wrote:
>> Hey guys,
>>
>> I have seen a lot of bad NUnit tests that unnecessarily compare
>> exception messages. They are wrong not only because they fail
>> in non-English Windows environment but also because those tests
>> will fail when Microsoft improves the messages. Furthermore, it
>> blocks possible message translation in the future.
>> They have been blocking me from checking NUnit test sanity. And
>> thanks to that, now we actually have a lot of wrong compatibility
>> assumptions in our own tests. (I don't say incompatibility is bad
>> but they do not have to be asserted unnecessarily.)
>>
>> Let me repeat: let's not compare any localizable strings.
> 
> Atsushi: do you know if there's a way of switching to the standard 
> language as a fallback (en-US I presume) in order to fix these kind of 
> tests in non-English Win environments?
> 
> Regards,
> 
> 	Andrés
>