[Mono-list] List.FindAll method implementation

Miguel de Icaza miguel at novell.com
Tue Mar 20 19:55:02 EDT 2007


Hey!

> I've just noticed the commit to List.FindAll(). Attached is an (small)
> optimization for the optimization:

This is fantastic ;-)

Please commit ;-)

If we could only do these kind of tuning everywhere ;-)

> - the resulting List<T> is built directly as an array which is later on
> wrapped by a List<T> object. This eliminates the unnecessary overhead of
> List.Add().
> - the filling of the result array stops as soon as all found items are
> processed. If there are no matches at the end of the original list, this
> will give an small performance win.
> 
> The test-run of the resulting code ran fine and it should always be
> faster than the version in svn.
> 
> 
> May I commit (with a changelog entry of course)?
> 
> - Juraj
> _______________________________________________
> Mono-list maillist  -  Mono-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-list



More information about the Mono-list mailing list