[Mono-list] System.Xml XmlTextReader 'resolver' ...

[Atsushi Eno]

Hi,

Michael Meeks wrote:
> 	It seems one constructor for XmlTextReader really requires a
> XmlResolver parameter [ perhaps instead of the dummy boolean ? ], such
> that we can resolve URIs correctly in the GetStreamFromUrl call inside
> the impl.

Sadly the patch is wrong - the XmlResolver in XmlReaderSettings is
used only to resolve DTD or whatever dependent files, not the XML
stream itself. For XML stream, you could just pass the stream
itself to one of the constructors (for example, by using your
XmlResolver.GetEntity()).

XmlResolver could be explicitly set null (which indicates that it
must skip external entity resolution) and in such case your patch
causes NullReferenceException. (I will add such case to our tests.)

> 	This was provoked by OdfConverter - which likes to stuff a whole load
> of XSLT magic inside the .exe itself :-)

What kind of issue was it?

Atsushi Eno