[Mono-list] [PATCH] Hard coded System.Environment.OSVersion...

[Sebastien Pouliot]

> I think we made the method report the hardcoded version to fool the
> broken sw which relies on the version.

That was my feeling ;-)
However by doing so we are also fooling the non-broken software and not
encouraging the creation of valid software.

> We may go with your changes and wait for someone to complain, or maybe
> we should check an environment variable like:
>
> 	PROGRAMMER_TOO_LAZY_TO_WRITE_PORTABLE_CODE=beatmeharder
> and report the fixed version in that case.

I don't like environment variables much but I do like your name ;-)
and the fact that the variable as nothing to do with the version returned.

However I don't think we have to do this on Windows because there's already
a "documented" way to fool application with versions numbers.
(yeah they have automated the non-portability lazyness ;-)

Does anyone know something that will break without the hardcoded version (as
pre-complain precaution) ?
or else I'll commit my original patch (without the C#/C++/C99 comments).

Sebastien Pouliot
http://pages.infinit.net/ctech/poupou.html

-----Original Message-----
From: mono-list-admin@lists.ximian.com
[mailto:mono-list-admin@lists.ximian.com]On Behalf Of Paolo Molaro
Sent: 26 avril 2004 10:08
To: mono-list@lists.ximian.com
Subject: Re: [Mono-list] [PATCH] Hard coded
System.Environment.OSVersion...


On 04/23/04 Sebastien Pouliot wrote:
> Here's the patches. There may be a better way on Linux to get a version...
>
> The following code...
>
> static void Main(string[] args)
> {
> 	Console.WriteLine (Environment.OSVersion.ToString ());
> 	Console.WriteLine (Environment.OSVersion.Platform);
> 	Console.WriteLine (Environment.OSVersion.Version);
> }
>
> Should display on Linux...
>
> [poupou@rh9 poupou]$ mono version.exe
> Unix 2.4.20.8
> 128
> 2.4.20.8

I think we made the method report the hardcoded version to fool the
broken sw which relies on the version.
We may go with your changes and wait for someone to complain, or maybe
we should check an environment variable like:

	PROGRAMMER_TOO_LAZY_TO_WRITE_PORTABLE_CODE=beatmeharder
and report the fixed version in that case.

lupus

--
-----------------------------------------------------------------
lupus@debian.org                                     debian/rules
lupus@ximian.com                             Monkeys do it better
_______________________________________________
Mono-list maillist  -  Mono-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-list