[Mono-list] System.Collections.ArrayList Patch

Thong (Tum) Nguyen tum@veridicus.com
Sat, 3 May 2003 17:00:45 +1200


That won't work because the wrapper doesn't use dataArray.  The wrapped
list might not even be a wrapper.

I actually implemented these about a month ago and sent the patches to
Miguel.  I'm not sure why he didn't commit them :-\.

My implementation supported almost all the missing functions and had a
few bug fixes as well.  It also implemented sort *directly* on the inner
list rather than making a temporary copy of an array (so it would be
much faster).

My patch is attached.

Regards,

^Tum

> -----Original Message-----
> From: mono-list-admin@lists.ximian.com [mailto:mono-list-
> admin@lists.ximian.com] On Behalf Of Piers Haken
> Sent: Saturday, 3 May 2003 11:32 a.m.
> To: Ben Maurer; Mono List
> Subject: RE: [Mono-list] System.Collections.ArrayList Patch
> 
> I don't think you need to do the copy in Sort(). This should do it:
> 
> 	Array.Sort (dataArray, null, index, count, comparer);
> 
> Also those checks could just be moved into the most general
> Array.Sort().
> 
> Piers.
> 
> > -----Original Message-----
> > From: Ben Maurer [mailto:bmaurer@users.sourceforge.net]
> > Sent: Friday, May 02, 2003 2:51 PM
> > To: Mono List
> > Subject: [Mono-list] System.Collections.ArrayList Patch
> >
> >
> > Hi guys,
> >
> > As per Miguel's suggestion, I am cleaning up the
> > System.Collections namespace.
> >
> > I got the wrappers in the ArrayList working.
> >
> > Could someone do a sanity check on this. I will commit after
> > that is done.
> >
> > --Ben Maurer
> >
> _______________________________________________
> Mono-list maillist  -  Mono-list@lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-list