[Mono-list] Monitor.cs

Miguel de Icaza miguel@ximian.com
03 Jan 2003 20:03:50 -0500

Hello Pedro,

> I was looking the source of System.Threading.Monitor class and I saw a
> few mistakes (I think that they are mistakes). I changed that file and
> the new one is attached to this mail. Please, see it and tell me what do
> you think about.

Could you provide a ChangeLog for your changes?  I looked over it, and I

	* re-format changes.

	* This pattern:

-			int ms=Convert.ToInt32(timeout.TotalMilliseconds);
+			double ms = timeout.TotalMilliseconds;

	  But I am not sure about what this does, or why the change was needed
	* This other:

-			// FIXME when I understand what a
-			// "synchronisation domain" is and does
-			return(false);
+			return Wait(obj,msi,exitContext);

	  This seems to be the main fix in the patch, is that what you were fixing?

	  What was the problem that this patch fixes?