[Mono-list] Patch for DataTime.cs

Alan Tam Tam@SiuLung.com
Fri, 28 Feb 2003 03:58:15 +0800


The patch for DateTime.cs applied. Thank you.

However, for the patch on DateTimeFormatInfo.cs, I found both the pre-patch and
post-patch implementations wrong. [Short/Long] [Date/Time] should inherit from
the format specified by the system, i.e. control panel in Windows and LC_TIME
in Linux. (This conclusion is based on my test in MS implementation.) Please
discuss.

Regards,
Alan

----- Original Message -----
From: "Elan Feingold" <efeingold@mn.rr.com>
To: <mono-list@lists.ximian.com>
Sent: Friday, February 28, 2003 2:36 AM
Subject: RE: [Mono-list] Patch for DataTime.cs


* DateTime.cs: FileTime is expressed in Universal time, and as such must
be converted
before subtracting the magic offset.

* DateTime.cs: Strings in the format "2003-02-27T10:05:03-11:00" (note
the timezone
at the end) *must* be parsed by DateTime.Parse() for compatibility with
Microsoft. This came up in my work with XML [de]serialization, which
I'll send a patch for shortly

* DateTimeFormatInfo.cs: The date time format patterns didn't match MS
output.

> Can you add your tests to mcs/class/corlib/Test/....?

As soon as I can figure out how to run the test system, I'd be happy to.
Can you point a newbie like me at a web page or something to look at?
8-)

> What does patch 3 do? I mean, can you please write a few lines  la
> ChangeLog style?

Is the above what you're looking for? If not, let me know.

-elan