[Mono-list] some System.XML bugfixes

tim@timcoleman.com tim@timcoleman.com
Sat, 30 Nov 2002 16:17:09 -0500


> That CreateNavigator (XmlNode) should be protected, not public nor protected 
> internal IMHO. 

I would tend to agree, although I'm not sure why the .NET docs say 
otherwise.

I think that XmlDocument *should* have it declared as 
protected virtual XPathNavigator CreateNavigator (XmlNode node)
and then XmlDataDocument can have
protected override XPathNavigator CreateNavigator (XmlNode node)

This is especially true since XmlDocument and XmlDataDocument are
in different assemblies.  Unless, maybe the second CreateNavigator
should be virtual instead of override.  Since CreateNavigator is
protected internal in XmlDocument, would it be true that XmlDataDocument
shouldn't even see that definition?

Just some food for thought.

-- 
Tim Coleman <tim@timcoleman.com>                       [43.43 N 80.45 W]
BMath, Honours Combinatorics and Optimization, University of Waterloo
Software Developer, Global Services, Open Text Corporation
"Under capitalism, man exploits man.  Under communism, it's just the
 opposite." -- J.K. Galbraith