[Mono-list] [PATCH] bitset doc

Paolo Molaro lupus@ximian.com
Sun, 2 Jun 2002 10:29:58 +0200


On 06/02/02 Dennis Haney wrote:
> Was this unecessary for such a easy interface... Well, could you guess
> that if you used mono_bitset_mem_new it is not freed even if
> mono_bitset_free is called on it?

:-)
I would add to the docs that the mem arguments must hold at least the
number of bytes returned by a call to mono_bitset_alloc_size() and since
the lib didn't allocate the memory (the user did), it can't free it
(since it may be stack memory, for example).
Also, I would remove references to malloc in the docs (it's also
incorrect, since we use g_malloc) and to g_return_if_fail() because
that is a debug check that mean the user has screwed up, but it's not
part of the interface (it gets removes in non-debug builds).
We put the documentation in the C file: can you prepare a new patch with
these changes? Otherwise I'll move the comments to the C file myself on
Monday.

Thanks!

> [OT]:
> Does anyone know why my messages seem to take hours to make it to the
> list? And why does mailman fail to send acknowledgements that it
> received my messages even when I said it should do so?

Mailman is stupid and it uses the Sender: header instead of the From:
one so I need to approve your posts (and your sender address bounces
so you don't get the message back).

lupus

-- 
-----------------------------------------------------------------
lupus@debian.org                                     debian/rules
lupus@ximian.com                             Monkeys do it better