[Mono-list] [patch] System.BitConverter impl

[Matt Kimball]

This is a multi-part message in MIME format...

------------=_1010516285-1335-0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: binary

Paolo Molaro wrote
> Could you put the CSCompliant attribute and the unsafe keyword only
> where it's really needed? Looks good otherwise.

Okay, I've fixed this.  Attached is a new version.

As an added bonus, I also fixed the code to throw the correct exceptions when
the arguments are invalid.

> Did you find somewhere in the spec if it should always convert to
> little endian when converting, say, an int to a byte array?
> Or should it convert to the native endianess?

The documentation doesn't specify, but the intent seems to be to always convert
to native endianness.  I believe my code will do this, but it will always
*report* that it is running on a little endian machine, right now.  This should
probably be some sort of 'configure' derived magic, but I've just hardcoded the
boolean variable which reports it to "Yes, you are running on a little endian
machine."

-- 
Matt Kimball
matt@kimball.net



------------=_1010516285-1335-0
Content-Type: application/octet-stream; name="BitConverter.cs"
Content-Disposition: attachment; filename="BitConverter.cs"
Content-Transfer-Encoding: base64

Ly8KLy8gU3lzdGVtLkJpdENvbnZlcnRlcgovLwovLyBBdXRob3I6Ci8vICAg
TWF0dCBLaW1iYWxsIChtYXR0QGtpbWJhbGwubmV0KQovLwoKdXNpbmcgU3lz
dGVtOwoKbmFtZXNwYWNlIFN5c3RlbSB7CglwdWJsaWMgY2xhc3MgQml0Q29u
dmVydGVyIHsKCQlbTW9ub1RPRE9dCS8vICBOb3QgYWxsIHRoZSB3b3JsZCdz
IGFuIHg4NgoJCXB1YmxpYyBzdGF0aWMgcmVhZG9ubHkgYm9vbCBJc0xpdHRs
ZUVuZGlhbiA9IHRydWU7CgoJCXB1YmxpYyBzdGF0aWMgbG9uZyBEb3VibGVU
b0ludDY0Qml0cyhkb3VibGUgdmFsdWUpIHsKCQkJcmV0dXJuIFRvSW50NjQo
R2V0Qnl0ZXModmFsdWUpLCAwKTsKCQl9CgoJCXB1YmxpYyBzdGF0aWMgZG91
YmxlIEludDY0Qml0c1RvRG91YmxlKGxvbmcgdmFsdWUpIHsKCQkJcmV0dXJu
IFRvRG91YmxlKEdldEJ5dGVzKHZhbHVlKSwgMCk7CgkJfQoKCQl1bnNhZmUg
c3RhdGljIGJ5dGVbXSBHZXRCeXRlcyhieXRlICpwdHIsIGludCBjb3VudCkg
ewoJCQlieXRlW10gcmV0ID0gbmV3IGJ5dGVbY291bnRdOwoKCQkJZm9yIChp
bnQgaSA9IDA7IGkgPCBjb3VudDsgaSsrKSB7CgkJCQlyZXRbaV0gPSBwdHJb
aV07CgkJCX0KCgkJCXJldHVybiByZXQ7CgkJfQoKCQl1bnNhZmUgcHVibGlj
IHN0YXRpYyBieXRlW10gR2V0Qnl0ZXMoYm9vbCB2YWx1ZSkgewoJCQlyZXR1
cm4gR2V0Qnl0ZXMoKGJ5dGUgKikmdmFsdWUsIDEpOwoJCX0KCgkJdW5zYWZl
IHB1YmxpYyBzdGF0aWMgYnl0ZVtdIEdldEJ5dGVzKGNoYXIgdmFsdWUpIHsK
CQkJcmV0dXJuIEdldEJ5dGVzKChieXRlICopJnZhbHVlLCAyKTsKCQl9CgoJ
CXVuc2FmZSBwdWJsaWMgc3RhdGljIGJ5dGVbXSBHZXRCeXRlcyhzaG9ydCB2
YWx1ZSkgewoJCQlyZXR1cm4gR2V0Qnl0ZXMoKGJ5dGUgKikmdmFsdWUsIDIp
OwoJCX0KCgkJdW5zYWZlIHB1YmxpYyBzdGF0aWMgYnl0ZVtdIEdldEJ5dGVz
KGludCB2YWx1ZSkgewoJCQlyZXR1cm4gR2V0Qnl0ZXMoKGJ5dGUgKikmdmFs
dWUsIDQpOwoJCX0KCgkJdW5zYWZlIHB1YmxpYyBzdGF0aWMgYnl0ZVtdIEdl
dEJ5dGVzKGxvbmcgdmFsdWUpIHsKCQkJcmV0dXJuIEdldEJ5dGVzKChieXRl
ICopJnZhbHVlLCA4KTsKCQl9CgoJCVtDTFNDb21wbGlhbnQoZmFsc2UpXQoJ
CXVuc2FmZSBwdWJsaWMgc3RhdGljIGJ5dGVbXSBHZXRCeXRlcyh1c2hvcnQg
dmFsdWUpIHsKCQkJcmV0dXJuIEdldEJ5dGVzKChieXRlICopJnZhbHVlLCAy
KTsKCQl9CgoJCVtDTFNDb21wbGlhbnQoZmFsc2UpXQoJCXVuc2FmZSBwdWJs
aWMgc3RhdGljIGJ5dGVbXSBHZXRCeXRlcyh1aW50IHZhbHVlKSB7CgkJCXJl
dHVybiBHZXRCeXRlcygoYnl0ZSAqKSZ2YWx1ZSwgNCk7CgkJfQoKCQlbQ0xT
Q29tcGxpYW50KGZhbHNlKV0KCQl1bnNhZmUgcHVibGljIHN0YXRpYyBieXRl
W10gR2V0Qnl0ZXModWxvbmcgdmFsdWUpIHsKCQkJcmV0dXJuIEdldEJ5dGVz
KChieXRlICopJnZhbHVlLCA4KTsKCQl9CgoJCXVuc2FmZSBwdWJsaWMgc3Rh
dGljIGJ5dGVbXSBHZXRCeXRlcyhmbG9hdCB2YWx1ZSkgewoJCQlyZXR1cm4g
R2V0Qnl0ZXMoKGJ5dGUgKikmdmFsdWUsIDQpOwoJCX0KCgkJdW5zYWZlIHB1
YmxpYyBzdGF0aWMgYnl0ZVtdIEdldEJ5dGVzKGRvdWJsZSB2YWx1ZSkgewoJ
CQlyZXR1cm4gR2V0Qnl0ZXMoKGJ5dGUgKikmdmFsdWUsIDgpOwoJCX0KCgkJ
dW5zYWZlIHN0YXRpYyB2b2lkIFB1dEJ5dGVzKGJ5dGUgKmRzdCwgYnl0ZVtd
IHNyYywgaW50IHN0YXJ0X2luZGV4LCBpbnQgY291bnQpIHsKCQkJaWYgKHNy
YyA9PSBudWxsKSB7CgkJCQl0aHJvdyBuZXcgQXJndW1lbnROdWxsRXhjZXB0
aW9uKCk7CgkJCX0KCgkJCWlmIChzcmMuTGVuZ3RoIDwgc3RhcnRfaW5kZXgg
KyBjb3VudCkgewoJCQkJdGhyb3cgbmV3IEFyZ3VtZW50T3V0T2ZSYW5nZUV4
Y2VwdGlvbigpOwoJCQl9CgoJCQlmb3IgKGludCBpID0gMDsgaSA8IGNvdW50
OyBpKyspIHsKCQkJCWRzdFtpXSA9IHNyY1tpICsgc3RhcnRfaW5kZXhdOwoJ
CQl9CgkJfQoKCQl1bnNhZmUgcHVibGljIHN0YXRpYyBib29sIFRvQm9vbGVh
bihieXRlW10gdmFsdWUsIGludCBzdGFydF9pbmRleCkgewoJCQlib29sIHJl
dDsKCgkJCVB1dEJ5dGVzKChieXRlICopJnJldCwgdmFsdWUsIHN0YXJ0X2lu
ZGV4LCAxKTsKCgkJCXJldHVybiByZXQ7CgkJfQoKCQl1bnNhZmUgcHVibGlj
IHN0YXRpYyBjaGFyIFRvQ2hhcihieXRlW10gdmFsdWUsIGludCBzdGFydF9p
bmRleCkgewoJCQljaGFyIHJldDsKCgkJCVB1dEJ5dGVzKChieXRlICopJnJl
dCwgdmFsdWUsIHN0YXJ0X2luZGV4LCAyKTsKCgkJCXJldHVybiByZXQ7CgkJ
fQoKCQl1bnNhZmUgcHVibGljIHN0YXRpYyBzaG9ydCBUb0ludDE2KGJ5dGVb
XSB2YWx1ZSwgaW50IHN0YXJ0X2luZGV4KSB7CgkJCXNob3J0IHJldDsKCgkJ
CVB1dEJ5dGVzKChieXRlICopJnJldCwgdmFsdWUsIHN0YXJ0X2luZGV4LCAy
KTsKCgkJCXJldHVybiByZXQ7CgkJfQoKCQl1bnNhZmUgcHVibGljIHN0YXRp
YyBpbnQgVG9JbnQzMihieXRlW10gdmFsdWUsIGludCBzdGFydF9pbmRleCkg
ewoJCQlpbnQgcmV0OwoKCQkJUHV0Qnl0ZXMoKGJ5dGUgKikmcmV0LCB2YWx1
ZSwgc3RhcnRfaW5kZXgsIDQpOwoKCQkJcmV0dXJuIHJldDsKCQl9CgoJCXVu
c2FmZSBwdWJsaWMgc3RhdGljIGxvbmcgVG9JbnQ2NChieXRlW10gdmFsdWUs
IGludCBzdGFydF9pbmRleCkgewoJCQlsb25nIHJldDsKCgkJCVB1dEJ5dGVz
KChieXRlICopJnJldCwgdmFsdWUsIHN0YXJ0X2luZGV4LCA4KTsKCgkJCXJl
dHVybiByZXQ7CgkJfQoKCQlbQ0xTQ29tcGxpYW50KGZhbHNlKV0KCQl1bnNh
ZmUgcHVibGljIHN0YXRpYyB1c2hvcnQgVG9VSW50MTYoYnl0ZVtdIHZhbHVl
LCBpbnQgc3RhcnRfaW5kZXgpIHsKCQkJdXNob3J0IHJldDsKCgkJCVB1dEJ5
dGVzKChieXRlICopJnJldCwgdmFsdWUsIHN0YXJ0X2luZGV4LCAyKTsKCgkJ
CXJldHVybiByZXQ7CgkJfQoKCQlbQ0xTQ29tcGxpYW50KGZhbHNlKV0KCQl1
bnNhZmUgcHVibGljIHN0YXRpYyB1aW50IFRvVUludDMyKGJ5dGVbXSB2YWx1
ZSwgaW50IHN0YXJ0X2luZGV4KSB7CgkJCXVpbnQgcmV0OwoKCQkJUHV0Qnl0
ZXMoKGJ5dGUgKikmcmV0LCB2YWx1ZSwgc3RhcnRfaW5kZXgsIDQpOwoKCQkJ
cmV0dXJuIHJldDsKCQl9CgoJCVtDTFNDb21wbGlhbnQoZmFsc2UpXQoJCXVu
c2FmZSBwdWJsaWMgc3RhdGljIHVsb25nIFRvVUludDY0KGJ5dGVbXSB2YWx1
ZSwgaW50IHN0YXJ0X2luZGV4KSB7CgkJCXVsb25nIHJldDsKCgkJCVB1dEJ5
dGVzKChieXRlICopJnJldCwgdmFsdWUsIHN0YXJ0X2luZGV4LCA4KTsKCgkJ
CXJldHVybiByZXQ7CgkJfQoKCQl1bnNhZmUgcHVibGljIHN0YXRpYyBmbG9h
dCBUb1NpbmdsZShieXRlW10gdmFsdWUsIGludCBzdGFydF9pbmRleCkgewoJ
CQlmbG9hdCByZXQ7CgoJCQlQdXRCeXRlcygoYnl0ZSAqKSZyZXQsIHZhbHVl
LCBzdGFydF9pbmRleCwgNCk7CgoJCQlyZXR1cm4gcmV0OwoJCX0KCgkJdW5z
YWZlIHB1YmxpYyBzdGF0aWMgZG91YmxlIFRvRG91YmxlKGJ5dGVbXSB2YWx1
ZSwgaW50IHN0YXJ0X2luZGV4KSB7CgkJCWRvdWJsZSByZXQ7CgoJCQlQdXRC
eXRlcygoYnl0ZSAqKSZyZXQsIHZhbHVlLCBzdGFydF9pbmRleCwgOCk7CgoJ
CQlyZXR1cm4gcmV0OwoJCX0KCgkJcHVibGljIHN0YXRpYyBzdHJpbmcgVG9T
dHJpbmcoYnl0ZVtdIHZhbHVlKSB7CgkJCXJldHVybiBUb1N0cmluZyh2YWx1
ZSwgMCwgdmFsdWUuTGVuZ3RoKTsKCQl9CgoJCXB1YmxpYyBzdGF0aWMgc3Ry
aW5nIFRvU3RyaW5nKGJ5dGVbXSB2YWx1ZSwgaW50IHN0YXJ0X2luZGV4KSB7
CgkJCWlmIChzdGFydF9pbmRleCA+PSB2YWx1ZS5MZW5ndGgpIHsKCQkJCXRo
cm93IG5ldyBBcmd1bWVudE91dE9mUmFuZ2VFeGNlcHRpb24oKTsKCQkJfQoK
CQkJcmV0dXJuIFRvU3RyaW5nKHZhbHVlLCBzdGFydF9pbmRleCwgdmFsdWUu
TGVuZ3RoIC0gc3RhcnRfaW5kZXgpOwoJCX0KCgkJcHVibGljIHN0YXRpYyBz
dHJpbmcgVG9TdHJpbmcoYnl0ZVtdIHZhbHVlLCBpbnQgc3RhcnRfaW5kZXgs
IGludCBsZW5ndGgpIHsKCQkJaWYgKHZhbHVlID09IG51bGwpIHsKCQkJCXRo
cm93IG5ldyBBcmd1bWVudE51bGxFeGNlcHRpb24oKTsKCQkJfQoKCQkJaWYg
KHN0YXJ0X2luZGV4IDwgMCB8fCBsZW5ndGggPCAwIHx8IHN0YXJ0X2luZGV4
ICsgbGVuZ3RoID4gdmFsdWUuTGVuZ3RoKSB7CgkJCQl0aHJvdyBuZXcgQXJn
dW1lbnRPdXRPZlJhbmdlRXhjZXB0aW9uKCk7CgkJCX0KCgkJCXN0cmluZyBy
ZXQgPSAiIjsKCgkJCWZvciAoaW50IGkgPSAwOyBpIDwgdmFsdWUuTGVuZ3Ro
OyBpKyspIHsKCQkJCWlmIChpID4gMCkKCQkJCQlyZXQgPSByZXQgKyAnLSc7
CgkJCQkKCQkJCWNoYXIgaGlnaCA9IChjaGFyKSgodmFsdWVbaV0gPj4gNCkg
JiAweDBmKTsKCQkJCWNoYXIgbG93ID0gKGNoYXIpKHZhbHVlW2ldICYgMHgw
Zik7CgoJCQkJaWYgKGhpZ2ggPCAxMCkgCgkJCQkJaGlnaCArPSAnMCc7CgkJ
CQllbHNlCgkJCQkJaGlnaCArPSAnQSc7CgoJCQkJaWYgKGxvdyA8IDEwKQoJ
CQkJCWxvdyArPSAnMCc7CgkJCQllbHNlCgkJCQkJbG93ICs9ICdBJzsKCgkJ
CQlyZXQgPSByZXQgKyBoaWdoICsgbG93OwoJCQl9CgoJCQlyZXR1cm4gcmV0
OwoJCX0KCX0KfQo=

------------=_1010516285-1335-0--