[Mono-list] System.Reflection and MethodImplOptions

[Matt Kimball]

This is a multi-part message in MIME format...

------------=_1010448390-17338-0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: binary

Hello, all.

I recently grabbed the latest mcs from CVS and started playing with it. 
Everything built smoothly once I figure out a thing or two about MS's .NET SDK,
except some of the stuff in System.Reflection didn't build cleanly because some
of the source files pull in both System.Runtime.CompilerServices and
System.Runtime.InteropServices, and then expect to use constants from
MethodImplOptions from CompilerServices without fully qualifying the where they
are coming from.  

So, I was getting build errors when building corlib.dll.

The attached patch fixes that problem.

Best,
-- 
Matt Kimball
matt@kimball.net



------------=_1010448390-17338-0
Content-Type: application/octet-stream; name="reflmethod.patch"
Content-Disposition: attachment; filename="reflmethod.patch"
Content-Transfer-Encoding: base64

SW5kZXg6IGNsYXNzL2NvcmxpYi9TeXN0ZW0uUmVmbGVjdGlvbi9Nb25vRmll
bGQuY3MKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL21vbm8v
bWNzL2NsYXNzL2NvcmxpYi9TeXN0ZW0uUmVmbGVjdGlvbi9Nb25vRmllbGQu
Y3MsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMQpkaWZmIC11IC1yMS4xIE1v
bm9GaWVsZC5jcwotLS0gY2xhc3MvY29ybGliL1N5c3RlbS5SZWZsZWN0aW9u
L01vbm9GaWVsZC5jcwkxMyBEZWMgMjAwMSAxNTo1NzoyMiAtMDAwMAkxLjEK
KysrIGNsYXNzL2NvcmxpYi9TeXN0ZW0uUmVmbGVjdGlvbi9Nb25vRmllbGQu
Y3MJNyBKYW4gMjAwMiAyMzo1NzoxNiAtMDAwMApAQCAtMjIsNyArMjIsNyBA
QAogCQlwdWJsaWMgU3RyaW5nIG5hbWU7CiAJCXB1YmxpYyBGaWVsZEF0dHJp
YnV0ZXMgYXR0cnM7CiAJCQotCQlbTWV0aG9kSW1wbEF0dHJpYnV0ZShNZXRo
b2RJbXBsT3B0aW9ucy5JbnRlcm5hbENhbGwpXQorCQlbTWV0aG9kSW1wbEF0
dHJpYnV0ZShTeXN0ZW0uUnVudGltZS5Db21waWxlclNlcnZpY2VzLk1ldGhv
ZEltcGxPcHRpb25zLkludGVybmFsQ2FsbCldCiAJCWludGVybmFsIHN0YXRp
YyBleHRlcm4gdm9pZCBnZXRfZmllbGRfaW5mbyAoTW9ub0ZpZWxkIGZpZWxk
LCBvdXQgTW9ub0ZpZWxkSW5mbyBpbmZvKTsKIAl9CiAKSW5kZXg6IGNsYXNz
L2NvcmxpYi9TeXN0ZW0uUmVmbGVjdGlvbi9Nb25vTWV0aG9kLmNzCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9tb25vL21jcy9jbGFzcy9j
b3JsaWIvU3lzdGVtLlJlZmxlY3Rpb24vTW9ub01ldGhvZC5jcyx2CnJldHJp
ZXZpbmcgcmV2aXNpb24gMS4zCmRpZmYgLXUgLXIxLjMgTW9ub01ldGhvZC5j
cwotLS0gY2xhc3MvY29ybGliL1N5c3RlbS5SZWZsZWN0aW9uL01vbm9NZXRo
b2QuY3MJNCBKYW4gMjAwMiAxNjowNjo1NSAtMDAwMAkxLjMKKysrIGNsYXNz
L2NvcmxpYi9TeXN0ZW0uUmVmbGVjdGlvbi9Nb25vTWV0aG9kLmNzCTcgSmFu
IDIwMDIgMjM6NTc6MTcgLTAwMDAKQEAgLTIxLDEwICsyMSwxMCBAQAogCQlp
bnRlcm5hbCBNZXRob2RBdHRyaWJ1dGVzIGF0dHJzOwogCQlpbnRlcm5hbCBN
ZXRob2RJbXBsQXR0cmlidXRlcyBpYXR0cnM7CiAKLQkJW01ldGhvZEltcGxB
dHRyaWJ1dGUoTWV0aG9kSW1wbE9wdGlvbnMuSW50ZXJuYWxDYWxsKV0KKwkJ
W01ldGhvZEltcGxBdHRyaWJ1dGUoU3lzdGVtLlJ1bnRpbWUuQ29tcGlsZXJT
ZXJ2aWNlcy5NZXRob2RJbXBsT3B0aW9ucy5JbnRlcm5hbENhbGwpXQogCQlp
bnRlcm5hbCBzdGF0aWMgZXh0ZXJuIHZvaWQgZ2V0X21ldGhvZF9pbmZvIChS
dW50aW1lTWV0aG9kSGFuZGxlIGhhbmRsZSwgb3V0IE1vbm9NZXRob2RJbmZv
IGluZm8pOwogCQkKLQkJW01ldGhvZEltcGxBdHRyaWJ1dGUoTWV0aG9kSW1w
bE9wdGlvbnMuSW50ZXJuYWxDYWxsKV0KKwkJW01ldGhvZEltcGxBdHRyaWJ1
dGUoU3lzdGVtLlJ1bnRpbWUuQ29tcGlsZXJTZXJ2aWNlcy5NZXRob2RJbXBs
T3B0aW9ucy5JbnRlcm5hbENhbGwpXQogCQlpbnRlcm5hbCBzdGF0aWMgZXh0
ZXJuIFBhcmFtZXRlckluZm9bXSBnZXRfcGFyYW1ldGVyX2luZm8gKFJ1bnRp
bWVNZXRob2RIYW5kbGUgaGFuZGxlKTsKIAl9OwogCQpJbmRleDogY2xhc3Mv
Y29ybGliL1N5c3RlbS5SZWZsZWN0aW9uL01vbm9Qcm9wZXJ0eS5jcwo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvbW9uby9tY3MvY2xhc3Mv
Y29ybGliL1N5c3RlbS5SZWZsZWN0aW9uL01vbm9Qcm9wZXJ0eS5jcyx2CnJl
dHJpZXZpbmcgcmV2aXNpb24gMS4yCmRpZmYgLXUgLXIxLjIgTW9ub1Byb3Bl
cnR5LmNzCi0tLSBjbGFzcy9jb3JsaWIvU3lzdGVtLlJlZmxlY3Rpb24vTW9u
b1Byb3BlcnR5LmNzCTQgSmFuIDIwMDIgMTY6MDY6NTUgLTAwMDAJMS4yCisr
KyBjbGFzcy9jb3JsaWIvU3lzdGVtLlJlZmxlY3Rpb24vTW9ub1Byb3BlcnR5
LmNzCTcgSmFuIDIwMDIgMjM6NTc6MTggLTAwMDAKQEAgLTI0LDcgKzI0LDcg
QEAKIAkJcHVibGljIE1ldGhvZEluZm8gc2V0X21ldGhvZDsKIAkJcHVibGlj
IFByb3BlcnR5QXR0cmlidXRlcyBhdHRyczsKIAkJCi0JCVtNZXRob2RJbXBs
QXR0cmlidXRlKE1ldGhvZEltcGxPcHRpb25zLkludGVybmFsQ2FsbCldCisJ
CVtNZXRob2RJbXBsQXR0cmlidXRlKFN5c3RlbS5SdW50aW1lLkNvbXBpbGVy
U2VydmljZXMuTWV0aG9kSW1wbE9wdGlvbnMuSW50ZXJuYWxDYWxsKV0KIAkJ
aW50ZXJuYWwgc3RhdGljIGV4dGVybiB2b2lkIGdldF9wcm9wZXJ0eV9pbmZv
IChNb25vUHJvcGVydHkgcHJvcCwgb3V0IE1vbm9Qcm9wZXJ0eUluZm8gaW5m
byk7CiAJfQogCg==

------------=_1010448390-17338-0--