[Mono-list] Re: [Mono-patches] mcs/class/System.Windows.Forms/System.Windows.Forms CaptionButton.cs,NONE,1.1 CharacterCasing.cs,NONE,1.1 CheckState.cs,NONE,1.1 DataGridParentRowsLabelStyle.cs,NONE,1.1 DialogResult.cs,NONE,1.1 DockStyle.cs,NONE,1.1 DragActio

Duncan Mak duncan@ximian.com
10 Apr 2002 23:16:44 -0400
Previous message: [Mono-list] Short news...
Next message: [Mono-list] System.DirectoryServices namespace
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
--=-sKhTLvY63MnrQHsZzh6/
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Wed, 2002-04-10 at 17:43, Dennis Hayes wrote:
> Update of /cvs/public/mcs/class/System.Windows.Forms/System.Windows.Forms
> In directory mono-cvs.ximian.com:/tmp/cvs-serv30436
> 
> Added Files:
> 	CaptionButton.cs CharacterCasing.cs CheckState.cs 
> 	DataGridParentRowsLabelStyle.cs DialogResult.cs DockStyle.cs 
> 	DragAction.cs DragDropEffects.cs DrawItemState.cs DrawMode.cs 
> 	ErrorBlinkStyle.cs ErrorIconAlignment.cs FlatStyle.cs 
> 	FormBorderStyle.cs FormStartPosition.cs FormWindowState.cs 
> 	FrameStyle.cs 
> Log Message:
> * Initial checkin for a number of enums *
> 

Please, please use Enumcheck (in mcs/tools) before committing any Enums,
as it is important that the layout of our Enums are compatible with
Microsoft's.

Also, please always assign values to Enums, instead of implicitly
relying on the order in the code. That way the enums are less prone to
changes in their layout when new fields are added.

I went thru the Enums you checked in and changed the layout accordingly. This is the patch.

Duncan.

--=-sKhTLvY63MnrQHsZzh6/
Content-Disposition: attachment; filename=System.Windows.Forms.Enums.patch
Content-Transfer-Encoding: quoted-printable
Content-Type: text/x-patch; name=System.Windows.Forms.Enums.patch; charset=ISO-8859-1

Index: class/System.Windows.Forms/System.Windows.Forms/FrameStyle.cs
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/public/mcs/class/System.Windows.Forms/System.Windows.Forms/F=
rameStyle.cs,v
retrieving revision 1.1
diff -u -5 -r1.1 FrameStyle.cs
--- class/System.Windows.Forms/System.Windows.Forms/FrameStyle.cs	10 Apr 20=
02 21:43:31 -0000	1.1
+++ class/System.Windows.Forms/System.Windows.Forms/FrameStyle.cs	10 Apr 20=
02 23:23:39 -0000
@@ -16,9 +16,9 @@
   /// Specifies the frame style of the selected control.=0D
 	/// </summary>=0D
 	[Serializable]=0D
 	public enum FrameStyle=0D
 	{=0D
-		Dashed,=0D
-		Thick=0D
+		Dashed =3D 0,=0D
+		Thick =3D 1,=0D
 	}=0D
-}
\ No newline at end of file
+}=0D
Index: class/System.Windows.Forms/System.Windows.Forms/FormWindowState.cs
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/public/mcs/class/System.Windows.Forms/System.Windows.Forms/F=
ormWindowState.cs,v
retrieving revision 1.1
diff -u -5 -r1.1 FormWindowState.cs
--- class/System.Windows.Forms/System.Windows.Forms/FormWindowState.cs	10 A=
pr 2002 21:43:31 -0000	1.1
+++ class/System.Windows.Forms/System.Windows.Forms/FormWindowState.cs	10 A=
pr 2002 23:23:39 -0000
@@ -17,10 +17,10 @@
 	/// </summary>=0D
 	[Serializable]=0D
 //	[ComVisible(true)]=0D
 	public enum FormWindowState=0D
 	{=0D
-		Maximized,=0D
-		Minimized,=0D
-		Normal=0D
+		Normal =3D 0,=0D
+		Maximized =3D 1,=0D
+		Minimized =3D 2,=0D
 	}=0D
-}
\ No newline at end of file
+}=0D
Index: class/System.Windows.Forms/System.Windows.Forms/FormStartPosition.cs
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/public/mcs/class/System.Windows.Forms/System.Windows.Forms/F=
ormStartPosition.cs,v
retrieving revision 1.1
diff -u -5 -r1.1 FormStartPosition.cs
--- class/System.Windows.Forms/System.Windows.Forms/FormStartPosition.cs	10=
 Apr 2002 21:43:31 -0000	1.1
+++ class/System.Windows.Forms/System.Windows.Forms/FormStartPosition.cs	10=
 Apr 2002 23:23:39 -0000
@@ -17,12 +17,12 @@
 	/// </summary>=0D
 	[Serializable]=0D
 //	[ComVisible(true)]=0D
 	public enum FormStartPosition=0D
 	{=0D
-		CenterParent,=0D
-		CenterScreen,=0D
-		Manual,=0D
-		WindowsDefaultBounds,=0D
-		WindowsDefaultLocation=0D
+		Manual =3D 0,=0D
+		CenterScreen =3D 1,=0D
+		WindowsDefaultLocation =3D 2,=0D
+		WindowsDefaultBounds =3D 3,=0D
+		CenterParent =3D 4,	=09=0D
 	}=0D
-}
\ No newline at end of file
+}=0D
Index: class/System.Windows.Forms/System.Windows.Forms/FormBorderStyle.cs
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/public/mcs/class/System.Windows.Forms/System.Windows.Forms/F=
ormBorderStyle.cs,v
retrieving revision 1.1
diff -u -5 -r1.1 FormBorderStyle.cs
--- class/System.Windows.Forms/System.Windows.Forms/FormBorderStyle.cs	10 A=
pr 2002 21:43:31 -0000	1.1
+++ class/System.Windows.Forms/System.Windows.Forms/FormBorderStyle.cs	10 A=
pr 2002 23:23:39 -0000
@@ -17,14 +17,14 @@
 	/// </summary>=0D
 	[Serializable]=0D
 	[ComVisible(true)]=0D
 	public enum FormBorderStyle=0D
 	{=0D
-		Fixed3D =3D 1,=0D
-		FixedDialog =3D 2,=0D
-		FixedSingle =3D 3,=0D
-		FixedToolWindow =3D 4,=0D
 		None =3D 0,=0D
-		Sizable =3D 5,=0D
+		FixedSingle =3D 1,=0D
+		Fixed3D =3D 2,=0D
+		FixedDialog =3D 3,=0D
+		Sizable =3D 4,=0D
+		FixedToolWindows =3D 5,=0D
 		SizableToolWindow =3D 6=0D
 	}=0D
-}
\ No newline at end of file
+}=0D
Index: class/System.Windows.Forms/System.Windows.Forms/FlatStyle.cs
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/public/mcs/class/System.Windows.Forms/System.Windows.Forms/F=
latStyle.cs,v
retrieving revision 1.1
diff -u -5 -r1.1 FlatStyle.cs
--- class/System.Windows.Forms/System.Windows.Forms/FlatStyle.cs	10 Apr 200=
2 21:43:31 -0000	1.1
+++ class/System.Windows.Forms/System.Windows.Forms/FlatStyle.cs	10 Apr 200=
2 23:23:39 -0000
@@ -16,11 +16,11 @@
   /// Specifies the appearance of a control.=0D
 	/// </summary>=0D
 	[Serializable]=0D
 	public enum FlatStyle=0D
 	{=0D
-		Flat,=0D
-		Popup,=0D
-		Standard,=0D
-		System=0D
+		Flat =3D 0,=0D
+		Popup =3D 1,=0D
+		Standard =3D 2,=0D
+		System =3D 3,=0D
 	}=0D
-}
\ No newline at end of file
+}=0D
Index: class/System.Windows.Forms/System.Windows.Forms/ErrorIconAlignment.c=
s
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/public/mcs/class/System.Windows.Forms/System.Windows.Forms/E=
rrorIconAlignment.cs,v
retrieving revision 1.1
diff -u -5 -r1.1 ErrorIconAlignment.cs
--- class/System.Windows.Forms/System.Windows.Forms/ErrorIconAlignment.cs	1=
0 Apr 2002 21:43:31 -0000	1.1
+++ class/System.Windows.Forms/System.Windows.Forms/ErrorIconAlignment.cs	1=
0 Apr 2002 23:23:39 -0000
@@ -17,13 +17,13 @@
   /// in relation to the control with an error.=20=0D
 	/// </summary>=0D
 	[Serializable]=0D
 	public enum ErrorIconAlignment=0D
 	{=0D
-		BottomLeft,=0D
-		BottomRight,=0D
-		MiddleLeft,=0D
-		MiddleRight,=0D
-		TopLeft,=0D
-		TopRight=0D
+		TopLeft =3D 0,=0D
+		TopRight =3D 1,=0D
+		MiddleLeft =3D 2,=0D
+		MiddleRight =3D 3,=0D
+		BottomLeft =3D 4,=0D
+		BottomRight =3D 5,=0D
 	}=0D
-}
\ No newline at end of file
+}=0D
Index: class/System.Windows.Forms/System.Windows.Forms/ErrorBlinkStyle.cs
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/public/mcs/class/System.Windows.Forms/System.Windows.Forms/E=
rrorBlinkStyle.cs,v
retrieving revision 1.1
diff -u -5 -r1.1 ErrorBlinkStyle.cs
--- class/System.Windows.Forms/System.Windows.Forms/ErrorBlinkStyle.cs	10 A=
pr 2002 21:43:31 -0000	1.1
+++ class/System.Windows.Forms/System.Windows.Forms/ErrorBlinkStyle.cs	10 A=
pr 2002 23:23:39 -0000
@@ -17,10 +17,10 @@
   /// should blink to alert the user that an error has occurred.=0D
 	/// </summary>=0D
 	[Serializable]=0D
 	public enum ErrorBlinkStyle=0D
 	{=0D
-		AlwaysBlink,=0D
-		BlinkIfDifferentError,=0D
-		NeverBlink=20=0D
+		BlinkIfDifferentError =3D 0,=0D
+		AlwaysBlink =3D 1,=0D
+		NeverBlink =3D 2,=0D
 	}=0D
-}
\ No newline at end of file
+}=0D
Index: class/System.Windows.Forms/System.Windows.Forms/DrawMode.cs
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/public/mcs/class/System.Windows.Forms/System.Windows.Forms/D=
rawMode.cs,v
retrieving revision 1.1
diff -u -5 -r1.1 DrawMode.cs
--- class/System.Windows.Forms/System.Windows.Forms/DrawMode.cs	10 Apr 2002=
 21:43:31 -0000	1.1
+++ class/System.Windows.Forms/System.Windows.Forms/DrawMode.cs	10 Apr 2002=
 23:23:39 -0000
@@ -16,10 +16,10 @@
   /// Specifies how the elements of a control are drawn.=0D
 	/// </summary>=0D
 	[Serializable]=0D
 	public enum DrawMode=0D
 	{=0D
-		Normal,=0D
-		OwnerDrawFixed,=0D
-		OwnerDrawVariable=20=0D
+		Normal =3D 0,=0D
+		OwnerDrawFixed =3D 1,=0D
+		OwnerDrawVariable =3D 2,=0D
 	}=0D
-}
\ No newline at end of file
+}=0D
Index: class/System.Windows.Forms/System.Windows.Forms/DrawItemState.cs
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/public/mcs/class/System.Windows.Forms/System.Windows.Forms/D=
rawItemState.cs,v
retrieving revision 1.1
diff -u -5 -r1.1 DrawItemState.cs
--- class/System.Windows.Forms/System.Windows.Forms/DrawItemState.cs	10 Apr=
 2002 21:43:31 -0000	1.1
+++ class/System.Windows.Forms/System.Windows.Forms/DrawItemState.cs	10 Apr=
 2002 23:23:39 -0000
@@ -18,19 +18,19 @@
 	/// </summary>=0D
 	[Flags]=0D
 	[Serializable]=0D
 	public enum DrawItemState=0D
 	{=0D
-		Checked =3D 1,=0D
-		ComboBoxEdit =3D 2,=0D
-		Default =3D 4,=0D
-		Disabled =3D 8,=0D
+		None =3D 0,=0D
+		Selected =3D 1,=0D
+		Grayed =3D 2,=0D
+		Disabled =3D 4,=0D
+		Checked =3D 8,=0D
 		Focus =3D 16,=0D
-		Grayed =3D 32,=0D
+		Default =3D 32,=0D
 		HotLight =3D 64,=0D
 		Inactive =3D 128,=0D
 		NoAccelerator =3D 256,=0D
 		NoFocusRect =3D 512,=0D
-		None =3D 0,=0D
-		Selected =3D 1024,=0D
+		ComboBoxEdit =3D 1024,=0D
 	}=0D
-}
\ No newline at end of file
+}=0D
Index: class/System.Windows.Forms/System.Windows.Forms/DragDropEffects.cs
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/public/mcs/class/System.Windows.Forms/System.Windows.Forms/D=
ragDropEffects.cs,v
retrieving revision 1.1
diff -u -5 -r1.1 DragDropEffects.cs
--- class/System.Windows.Forms/System.Windows.Forms/DragDropEffects.cs	10 A=
pr 2002 21:43:31 -0000	1.1
+++ class/System.Windows.Forms/System.Windows.Forms/DragDropEffects.cs	10 A=
pr 2002 23:23:39 -0000
@@ -18,13 +18,13 @@
 	/// </summary>=0D
 	[Flags]=0D
 	[Serializable]=0D
 	public enum DragDropEffects=0D
 	{=0D
-		All =3D 1,=0D
-		Copy =3D 2,=0D
-		Link =3D 4,=0D
-		Move =3D 8,=0D
 		None =3D 0,=0D
-		Scroll =3D 16=0D
+		Copy =3D 1,=0D
+		Move =3D 2,=0D
+	=09
 	}=0D
-}
\ No newline at end of file
+}=0D
Index: class/System.Windows.Forms/System.Windows.Forms/CharacterCasing.cs
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/public/mcs/class/System.Windows.Forms/System.Windows.Forms/C=
haracterCasing.cs,v
retrieving revision 1.1
diff -u -5 -r1.1 CharacterCasing.cs
--- class/System.Windows.Forms/System.Windows.Forms/CharacterCasing.cs	10 A=
pr 2002 21:43:31 -0000	1.1
+++ class/System.Windows.Forms/System.Windows.Forms/CharacterCasing.cs	10 A=
pr 2002 23:23:39 -0000
@@ -16,10 +16,10 @@
   /// Specifies the case of characters in a TextBox control.=0D
 	/// </summary>=0D
 	[Serializable]=0D
 	public enum CharacterCasing=0D
 	{=0D
-		Lower,=0D
-		Normal,=0D
-		Upper=0D
+		Normal =3D 0,=0D
+		Upper =3D 1,=0D
+		Lower =3D 2,=0D
 	}=0D
-}
\ No newline at end of file
+}=0D
Index: class/System.Windows.Forms/System.Windows.Forms/CaptionButton.cs
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/public/mcs/class/System.Windows.Forms/System.Windows.Forms/C=
aptionButton.cs,v
retrieving revision 1.1
diff -u -5 -r1.1 CaptionButton.cs
--- class/System.Windows.Forms/System.Windows.Forms/CaptionButton.cs	10 Apr=
 2002 21:43:31 -0000	1.1
+++ class/System.Windows.Forms/System.Windows.Forms/CaptionButton.cs	10 Apr=
 2002 23:23:39 -0000
@@ -17,12 +17,12 @@
 	/// </summary>=0D
=20=0D
 	[Serializable]=0D
 	public enum CaptionButton=0D
 	{=0D
-		Close,=0D
-		Help,=0D
-		Maximize,=0D
-		Minimize,=0D
-		Restore=0D
+		Close =3D 0,=0D
+		Minimize =3D 1,=0D
+		Minimize =3D 2,=0D
+		Restore =3D 3,=0D
+		Help =3D 4,=0D
 	}=0D
 }=0D

--=-sKhTLvY63MnrQHsZzh6/--
Previous message: [Mono-list] Short news...
Next message: [Mono-list] System.DirectoryServices namespace
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]