[Mono-list] Re: [Mono-cvs-list] Mono CVS: mcs piers

[Piers Haken]

Yes, sorry, my bad.

Here's a better entry if you want to fiddle the logs:

-----
Add constants for buffer size initialization
+Initialize():
	common initialization routine
	enforce minimum buffer size
	create buffer arrays up front
DiscardBufferedData():
	don't bother re-seeking internal stream
ReadBuffer():
	only need to support refilling empty buffer
	handle case where decoder doesn't return chars
Read():
	handle returning more chars than there are in the buffer
ReadToEnd():
	optimize null string case.
-----

Piers.

-----Original Message-----
From: Dick Porter [mailto:dick@ximian.com] 
Sent: Friday, April 05, 2002 11:07 AM
To: mono-list@ximian.com
Subject: [Mono-list] Re: [Mono-cvs-list] Mono CVS: mcs piers


On Fri, 2002-04-05 at 13:41, Piers Haken wrote:
> Changes by:	piers	02/04/05 07:41:07
> 
> Modified files:
> 	class/corlib/System.IO: StreamReader.cs
> 
> Log message:
> major cleanup

[dick@hrethel mcs] [ 8:02PM] 
:; cvs diff -r1.9 -r1.10 class/corlib/System.IO/StreamReader.cs |
diffstat  StreamReader.cs |  173
+++++++++++++++++++++++++++-----------------------------
 1 files changed, 84 insertions(+), 89 deletions(-)

Thanks for doing the code cleanup, but please in future don't forget to
add a ChangeLog entry too.  (Obviously we don't add change logs for typo
fixing, but pretty much anything more requires one.)

Thanks,

- Dick



_______________________________________________
Mono-list maillist  -  Mono-list@ximian.com
http://lists.ximian.com/mailman/listinfo/mono-list