[Mono-docs-list] Re: PATCH: resubmit

[Rafael Ferreira]

Hey Joshua, 

hehe... I don't have commit rights yet... I suppose I should pursue that
with miguel. But in the meantime, I'll make changes you pointed out
below and I'll take a look at the searching option. I tell you what tho,
browser.cs might have to be broken up, there's just too much logic in
that file and it would be a mess to tag even more to it. 

Ah also, I have a patch to the bookmarking logic that makes it behave
more like a web browser (where the "Add/Edit bookmark" options are
always available). I'll send that to you next. 

Any ideas/pointers on the searching? I'll take a look at dotlucene...

cheers,

- raf


On Tue, 2005-06-14 at 16:29 -0400, Joshua Tauberer wrote:
> Hey,
> 
> The patch is ok.  Feel free to commit (and thanks), but here are some 
> pedantic comments:
> 
> >         [Glade.Widget] TreeView PluginsTreeView;
> 
> Don't need that anymore.
> 
> > -				RootTree.UncompiledHelpSources.Add(args[i+1]);
> > +			    RootTree.UncompiledHelpSources.Add(args[i+1]);
> 
> Try to avoid those whitespace changes.
> 
> > +	      <property name="label" translatable="yes">&lt;span size=&quot;larger&quot;&gt;&lt;b&gt;monodoc:&lt;/b&gt; The Mono Documentation Library viewer&lt;/span&gt;</property>
> 
> Should be a capital 'v' in viewer, if the rest is going to be capitalized.
> 
> Say, I don't suppose you want to work on indexing/searching next?
>