[Mono-dev] [PATCH] Make sure mkbundle executables work if they are run from a path on the PATH environment variable.

[R Zaghi]

On Fri, Dec 1, 2017 at 7:20 PM, Miguel de Icaza <miguel at microsoft.com>
wrote:

> The patch looks great, as you work to submitting it via GitHub, can you
> make sure that you keep the exitsing code style for braces as well?
>
>
Ok. I tried my best to match the existing source file in style.
PR done.

Thanks
Ramin




>
>
> Miguel.
>
>
>
> *From: *R Zaghi <rzaghi at mosaic3dx.com>
> *Reply-To: *"rzaghi at mosaic3dx.com" <rzaghi at mosaic3dx.com>
> *Date: *Friday, December 1, 2017 at 2:12 PM
> *To: *Mono Devel Mailing List <mono-devel-list at lists.dot.net>
> *Cc: *Miguel de Icaza <miguel at microsoft.com>, Zoltan Varga <
> vargaz at gmail.com>
> *Subject: *[PATCH] Make sure mkbundle executables work if they are run
> from a path on the PATH environment variable.
>
>
>
> This is a patch to enable mkbundle executable files to work when they are
> run from a path that is on the PATH environment variable.
>
>
>
> Mono mini has a function probe_embedded() which looks for the program's
> file (using argv[0]). If the program is run from a path on the PATH
> environment variable then the open() fails and only a single parameter is
> sent to the mono_main() which in turn causes an if condition to print the
> help and exit.
>
>
>
> This patch searches through the directories specified in the current
> environment's PATH variable and tries to open() then first file found.
>
>
>
> Apologies if this is not the right way to submit patches but I had a quick
> look at the contribution page online and my understanding is that I must
> send a patch this to the community with the most likely or relevant
> owner(s) on the CC.
>
>
>
> Please let me know if I need to do anything else to push this (change
> log!?).
>
>
>
>
>
> Thanks
>
>
>
>
>
>
>
> Ramin Zaghi
>
>
>
> *Mosaic3DX™ | **User Interface Technology*
>
> St John's Innovation Centre,
>
> Cowley Road,
>
> Cambridge,
>
> CB4 0WS, UK
>
> *E*: rzaghi at mosaic3dx.com
>
> *T*: +44 1223 421 311 <+44%201223%20421311>
>
> http://linkedin.com/in/raminzaghi
> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flinkedin.com%2Fin%2Framinzaghi&data=02%7C01%7Cmiguel%40microsoft.com%7C5a055fb67e4e41ddc29608d538ef8150%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636477523678663881&sdata=XP4%2F51CxIMV13HjMarhw7dCtyS5A7na7BhkL8E2LrK8%3D&reserved=0>
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.dot.net/pipermail/mono-devel-list/attachments/20171201/41e4d12f/attachment.html>