[Mono-dev] Overflowed double->int casts on ARM in MS referencesource

Alexander Köplinger alex.koeplinger at outlook.com
Mon Mar 23 23:47:36 UTC 2015

I just noticed this commit by @spouliot: https://github.com/mono/mono/commit/298962b7ddd5e3af33c3177e8523cc36da4de553
In my opinion, this isn't the right approach, we should rather fix the cases where a cast would overflow in MS referencesource code rather than changing the tests.
I sent a PR a week or so ago that fixes the particular DateTime tests on ARM by explictly checking if the value fits into long, which I think is better: https://github.com/mono/referencesource/pull/8
There are a couple more of these overflows in MS code that make tests fail and I think we should discuss what the best approach is. What are your thoughts?
-- Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20150324/04a32cd8/attachment.html>

More information about the Mono-devel-list mailing list