[Mono-dev] If you accept pull requests on Mono's github

Edward Ned Harvey (mono) edward.harvey.mono at clevertrove.com
Sat Jan 3 20:42:56 UTC 2015


> From: mono-devel-list-bounces at lists.ximian.com [mailto:mono-devel-list-
> bounces at lists.ximian.com] On Behalf Of Miguel de Icaza
> 
> If you are accepting pull requests on Mono's github, please request that pull
> requests that were iterated multiple-times have their multiple commits
> squashed into one.

I consolidated a couple of commits into a single commit - Which is here:
https://github.com/rahvee/mono/commit/d684a099ba9e3bae1cb941523c0c978b16480ed4

Should I submit a pull request for this?  This test is known to succeed on .Net and fail on mono.  I don't know if you want tests that are known to fail.

The root cause is that the mono SslStream server, upon construction of the X509Certificate, strips the intermediate chain, so of course it cannot send the chain to a client, and the client cannot construct a chain.  Additionally, when the client attempts to construct a chain, X509Chain.Build() does not use the Intermediate store (which would be empty by default anyway) so the mono client is unable to compensate for the shortcoming of the server.


More information about the Mono-devel-list mailing list