[Mono-dev] System.Json string handling

[Andres G. Aragoneses]

Right, but an external reviewer can point out mistakes that can make the 
PR submitter improve the PR, which in turns makes it more likely that a 
Xamarin employee jumps and does the final merge operation.

On 21/09/14 20:28, 何子杰Hzj_jie wrote:
> The trouble here is, guys not in the mono team cannot merge the change
> to main branch even it has been reviewed by others.
>
> .Hzj_jie
> ------------------------------------------------------------------------
> From: Andres G. Aragoneses <mailto:knocte at gmail.com>
> Sent: ‎21/‎9/‎2014 23:20
> To: mono-devel-list at lists.ximian.com
> <mailto:mono-devel-list at lists.ximian.com>
> Subject: Re: [Mono-dev] System.Json string handling
>
> On 21/09/14 17:12, 何子杰Hzj_jie wrote:
>  > If the team does not want to let mono go worse. Then I would suggest to
>  > add more test cases, and a peer reviews.
>  > But if mono team is just simply ignoring pull requests out of core
>  > business, and trying to make mono close for other developers. Then just
>  > let other volunteers know, we properly can start another more open mono
>  > project.
>
> That's a good point. However, let's imagine we create such "OpenMono"
> project. We still wouldn't accept pull requests that haven't been
> reviewed by anyone, right?
>
> So then, the lesson maybe to learn here is that maybe it's not enough to
> propose pull requests, but one should review the pull requests of others
> before getting angry about Xamarin not having time to review patches.
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>