[Mono-dev] PR #1337 Review

[Miguel de Icaza]

Applied!

On Thu, Oct 30, 2014 at 2:01 PM, Alexander Köplinger <
alex.koeplinger at outlook.com> wrote:

> :-( The PR that fixes the test failures was submitted as
> https://github.com/mono/mono/pull/1380
> Can you revert the revert and apply the patch instead?
>
> -- Alex
>
>
>
> ------------------------------
> From: miguel at xamarin.com
> Date: Thu, 30 Oct 2014 13:54:48 -0400
> Subject: Re: [Mono-dev] PR #1337 Review
> To: alex.koeplinger at outlook.com
> CC: ryan.melena at noesislabs.com; mono-devel-list at lists.ximian.com
>
>
> I have reverted the patch for now.
>
> Miguel
>
> On Thu, Oct 30, 2014 at 12:49 PM, Alexander Köplinger <
> alex.koeplinger at outlook.com> wrote:
>
> Thanks for looking into it!
>
>
> ------------------------------
> Date: Thu, 30 Oct 2014 11:47:01 -0500
> Subject: Re: [Mono-dev] PR #1337 Review
> From: ryan.melena at noesislabs.com
> To: alex.koeplinger at outlook.com
>
> Turns out the IEnumerable<object> vs ArrayList issue was likely caused by
> an error in our initial Deserialize(string, Type) method implementation
> that we misdiagnosed as an issue with using ArrayList.  Working on a pull
> request to revert the ArrayList / List<object> changes to
> JavaScriptSerializer.cs file.
>
> Also found the source of the new unit test failure (an issue with our
> newest Deserialize(string, Type) method implementation) and will include a
> fix for that in the next pull request as well.
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20141030/642cf817/attachment-0001.html>