[Mono-dev] PR #1337 Review

Thu Oct 30 13:43:26 UTC 2014

You can run "make check FIXTURE=System.Web.Script.Serialization.JavaScriptSerializerTest" in mcs/class/System.Web.Extensions to only run the tests that are now failing.
As for ArrayList vs List<object>: can you add a unit test that verifies this?

-- Alex

Date: Thu, 30 Oct 2014 08:38:27 -0500
Subject: Re: [Mono-dev] PR #1337 Review
From: ryan.melena at noesislabs.com
To: alex.koeplinger at outlook.com
CC: miguel at xamarin.com; mono-devel-list at lists.ximian.com

I can take a look at the unit test problems but any help is appreciated.  I originally ran 'make check' and everything passed so I'm guessing these tests must not have been part of that script.
The change from ArrayList to List<object> is crucial because calling MS code assumes that the final result is an IEnumerable<object> (which an ArrayList is not).  It could conceivably be some other IEnumerable other than a List but I doubt that would fix the unit test issues.Owner
Cell: (612) 293-9161
ryan.melena at noesislabs.com
noesislabs.com

On Thu, Oct 30, 2014 at 8:23 AM, Alexander Köplinger <alex.koeplinger at outlook.com> wrote:

Hey, this breaks a few tests:

MonoTests.System.Web.Script.Serialization.JavaScriptSerializerTest.DeserializeDictionaryOfArrayList MonoTests.System.Web.Script.Serialization.JavaScriptSerializerTest.DeserializeObject MonoTests.System.Web.Script.Serialization.JavaScriptSerializerTest.InfinityAndNaN MonoTests.System.Web.Script.Serialization.JavaScriptSerializerTest.TestDeserialize MonoTests.System.Web.Script.Serialization.JavaScriptSerializerTest.TestDeserializeConverter1 MonoTests.System.Web.Script.Serialization.JavaScriptSerializerTest.TestDeserializeNonGenericOverload MonoTests.System.Web.Script.Serialization.JavaScriptSerializerTest.TestDeserializeTypeResolver MonoTests.System.Web.Script.Serialization.JavaScriptSerializerTest.TestSerialize1 

The TestDeserializeNonGenericOverload is a new one added by the PR (it passes on MS.NET though, so we should make it work on Mono).

I'm not sure the switch from ArrayList to List<object> is correct, if I change that back all tests pass again except the new TestDeserializeNonGenericOverload.

-- Alex

From: miguel at xamarin.com
Date: Wed, 29 Oct 2014 15:02:39 -0400
To: Ryan.Melena+Mono-Devel-List at noesislabs.com
CC: mono-devel-list at lists.ximian.com
Subject: Re: [Mono-dev] PR #1337 Review

Thanks for pointing this out.
Imlemented.
Miguel
On Wed, Oct 29, 2014 at 2:52 PM, RyanMelenaNoesis <Ryan.Melena+Mono-Devel-List at noesislabs.com> wrote:
It was requested that I notify the mailing list about this pull request ( https://github.com/mono/mono/pull/1337 ) in order to facilitate conversation.  The changes were implemented to support JWT authentication in our web application and required a couple changes to existing Mono code.  The changes to existing code were necessary to make Mono compatible with MS calling code and are explained in line comments.  Please let me know if anyone has particular concerns with this pull request.

_______________________________________________

Mono-devel-list mailing list

Mono-devel-list at lists.ximian.com

http://lists.ximian.com/mailman/listinfo/mono-devel-list

_______________________________________________
Mono-devel-list mailing list
Mono-devel-list at lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list 		 	   		  

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20141030/89e2f67c/attachment.html>