[Mono-dev] Review of PR1363: MembershipPasswordAttribute

[Martin Thwaites]

Hi all,

I've got a slight problem with this PR, and need some help to fix it.

It's a dependency issue, System.Web now depends on
System.ComponentModel.DataAnnotations.  However, the Makefile puts the
component model well after it in the compile order.

https://github.com/martinjt/mono/blob/master/mcs/class/Makefile

I've checked and the System.ComponentModel.DataAnnotations only depends on
System.Core and System.Xml, and System.Data

https://github.com/martinjt/mono/blob/master/mcs/class/System.ComponentModel.DataAnnotations/Makefile

So I was thinking of moving it up in the class/Makefile to just after the
System.Data reference.

Any ideas if this is not advisable anyone?

Thanks,
Martin

On 24 October 2014 22:49, Martin Thwaites <monoforum at my2cents.co.uk> wrote:

> Hi All,
>
> This is part of the ongoing work for the aspnetwebstack.  The only thing
> it's missing is tests around the PasswordStrength regex, however, I'm no
> good with regex so maybe someone can give me some to add to the test and
> valid/invalid strings to test against?
>
> I'm also hoping that the approach to testing this is ok.
>
> Finally, I've done some changes in the formatting a few times, but it's
> getting to the point where I can't see anything as I've looked at it too
> much.
>
> Please can someone give it a quick look over?
>
> Tests pass on Windows and Linux, I don't have a Mac to test it on but it
> doesn't do anything special.
>
> https://github.com/mono/mono/pull/1363
>
> Thanks,
> Martin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20141029/921e5716/attachment.html>