[Mono-dev] Heads up: Elimination of the 2.0 and 4.0 profiles

[Alexander Köplinger]

Hey Miguel,
 
sorry if that wasn't clear, I of course used a tool (https://github.com/fanf2/unifdef) to remove the ifdefs, doing that by hand would be little crazy :)
I also rebuilt and compared the assemblies to make sure nothing has changed. 
-- Alex
 
From: miguel at xamarin.com
Date: Wed, 22 Oct 2014 16:10:47 -0400
Subject: Re: [Mono-dev] Heads up: Elimination of the 2.0 and 4.0 profiles
To: alex.koeplinger at outlook.com
CC: mono-devel-list at lists.ximian.com

Hey Alex,
It is very repetitive work, so what I wanted to do was to write a perl script to remove the *obvious* ifdefs.   The tool would remove only those that match the following criteria (more or less):
Remove toplevel #if NET_2_0 with the final #endifOnly remove those that contain those preprocessor directivesAnd then have a human do the more fine-tuned approach.      There are a couple more defines that I remember could be automated, but I would love to have this in the form of a script.
I am afraid of applying a patch like that blindly, because there are no exact guarantees of what happened without reviewing the whole file.  So a script with the invariants would take a lot of my nervousness out.
Also, when I did it once, I had a setup where I rebuilt the assemblies and compared the output.  This would ensure that removal of ifdefs did not change the resulting binaries.
On Wed, Oct 22, 2014 at 4:04 PM, akoeplinger <alex.koeplinger at outlook.com> wrote:
Sounds like a good thing ;-)



I've got a branch in my fork where I removed the NET_2_0 ifdefs:

https://github.com/akoeplinger/mono/compare/remove-net20-ifdefs, @kumpera

told me a while ago that removing the 2.0 profile is on the horizon when I

asked about why the ifdefs are still there.



I refrained from making a PR so far because it is quite huge, do you think

now would be a good time?



-- Alex







--

View this message in context: http://mono.1490590.n4.nabble.com/Heads-up-Elimination-of-the-2-0-and-4-0-profiles-tp4664323p4664325.html

Sent from the Mono - Dev mailing list archive at Nabble.com.

_______________________________________________

Mono-devel-list mailing list

Mono-devel-list at lists.ximian.com

http://lists.ximian.com/mailman/listinfo/mono-devel-list


 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20141022/b8096b0f/attachment.html>