[Mono-dev] Review of PR #1347 - [MWF] Improve ellipsis handling on button

[Eberhard Beilharz]

Hi,

I'm working on some improvements on the experimental Pango rendering
support (see my pull request
<https://github.com/mono/libgdiplus/pull/27> in libgdiplus for details).

In doing so I came across some deficiencies in the MWF code that aren't
noticeable with the current Cairo rendering.

The changes in PR #1347 improve the handling of the ellipsis on buttons:

  * Don't subtract room for ellipsis. Ellipsis should be handled by the
    renderer so we shouldn't reserve space for it. Otherwise we end up
    not getting ellipsis (because the renderer thinks there is enough
    space available), or we don't use up the available space.
  * Don't allow text to go below button if we want to show ellipsis.

This change won't improve things with the Cairo renderer - I guess there
are other bugs in the Cairo renderer so that the ellipsis doesn't show.
But it also doesn't make things worse for the Cairo renderer. With the
experimental Pango renderer the ellipsis on buttons will show correctly
with this change and will match the behavior of .NET on Windows.

https://github.com/mono/mono/pull/1347

Thanks,
    Eberhard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20141021/d9598990/attachment.html>