[Mono-dev] State of aspnetwebstack on mono

[Martin Thwaites]

Hi Miguel,

The code that I'm referring to here is that of the aspnetwebstack on
codeplex.  That is to say that they are not something where you can remove
the code and recompile (unless there as a specific mono implementation
which is not ideal).  The goal is to have the compiled dlls that are
available on nuget work, without tweaking to a person's application.

I'll have a look and see if I can see where it would be used, but still as
you've said on one of my pulls, a half done implementation is better than
none.

Having the application throw a missing method exception should not be the
recommended approach when we can add the property and default it to false.

Thanks, and please don't think that things won't getting better with my
reviews.  I'm learning what you want so I can review better and help reduce
the burden on you and your staff.

Martin
On 20 Oct 2014 20:04, "Miguel de Icaza" <miguel at xamarin.com> wrote:

> As for the properties, although they should do something to the generated
>> urls, simply adding them should surely be a valid pull?  the issue at the
>> moment is that without them, you get an exception even if it should be
>> false.  I actually think that these are used by other classes when
>> generating urls, not the route collection itself, but I don't know for
>> sure.  Considering that adding them is very low risk, can we not just
>> accept the pull and ask for further work.
>>
> Nope, all they do is allow some code to be compiled, and then get the
> wrong result.
>
> You might as well remove the dependency of those properties, and see what
> else breaks on whatever piece of code you are trying to build.
>
> Miguel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20141020/6b34694f/attachment.html>