[Mono-dev] State of aspnetwebstack on mono

[Martin Thwaites]

Hi Miguel,

I did look at the Membership stuff, but it looked to me that the names
"made sense", therefore didn't think it was decompiled.

I haven't actually looked at that much so I'll implement it this week.

@Mike, mail me when you're done if you want and I'll review it.

As for the properties, although they should do something to the generated
urls, simply adding them should surely be a valid pull?  the issue at the
moment is that without them, you get an exception even if it should be
false.  I actually think that these are used by other classes when
generating urls, not the route collection itself, but I don't know for
sure.  Considering that adding them is very low risk, can we not just
accept the pull and ask for further work.

Thanks for looking at these Miguel.

Martin
On 20 Oct 2014 19:20, "Miguel de Icaza" <miguel at xamarin.com> wrote:

> Hey Mike,
>
> I would just submit a new pull request purely with code that you wrote,
> excluding any third party code.
>
> As for the WebRoute, like I mentioned, while it adds the properties, it
> looks broken, the properties *should* do something, currently they dont.
>
>
> On Mon, Oct 20, 2014 at 12:32 PM, Mike Morano <mmorano at mikeandwan.us>
> wrote:
>
>> Miguel,
>>
>> I can not apologize enough for the issue you point out in regards to the
>> poisoned patch, I had no idea it was sourced from MS.  I have been a big
>> mono fan since 2003, and certainly was not trying to jeopardize mono.  As I
>> identified in my commit message, I found that from another repo on github
>> when I was trying to see if anyone had already implemented this (similar to
>> how I found PR874 which was a pre-requisite), though will never do that
>> again.
>>
>> Are the files outside of the files listed in the other repo acceptable
>> (everything except MembershipPasswordAttribute.cs)?
>>
>> Sorry,
>> Mike
>>
>>
>>
>> On Mon, Oct 20, 2014 at 10:06 AM, Miguel de Icaza <miguel at xamarin.com>
>> wrote:
>>
>>> Hello,
>>>
>>> PR874 - from Chris Carroll with a few properties implemented around
>>>> routes
>>>>
>>>
>>> While the properties were added, they are not actually used for
>>> anything, this looks bogus.
>>>
>>> The tests basically show that setting a boolean property back and forth
>>> is set, but likely what needs to be tested is the other methods it affects.
>>>
>>> The point of these properties is to alter the behavior of the route
>>> collection.
>>>
>>>
>>>> PR1163 - from AerisG222 which includes a few changes around Unvalidated
>>>> parameters and some other bits
>>>>
>>>
>>> This patch is poisoned.
>>>
>>> There were a couple of elements that looked very suspicious, like this
>>> bit (which also, does not follow the Mono coding guidelines):
>>>
>>> 		int? _minRequiredPasswordLength;
>>> 		int? _minRequiredNonAlphanumericCharacters;
>>> 		string _passwordStrengthRegularExpression;
>>>
>>> 		readonly string _minRequiredPasswordLengthError = "{0} must have at least {1} characters";
>>> 		readonly string _minNonAlphanumericCharactersError = "{0} must have at least {1} special characters";
>>> 		readonly string _passwordStrengthError = "{0} is weak";
>>>
>>>
>>> What are the chances of getting every internal method name to match the
>>> one in .NET I asked myself?   Close to zero.   So this was clearly
>>> decompiled and submitted.
>>>
>>> Rejected.  Someone *else* that has not worked on that code will have to
>>> rewrite this, it is unacceptable to have people contribute decompiled code.
>>>
>>> PR1349 - From me regarding MachineKey.Protect methods
>>>>
>>>
>>> Added a comment, looks like it could go in, but we need tests for the
>>> Unprotect path.
>>>
>>> And I would like those to be tested against Windows as well.
>>>
>>>
>>>> PR1353 - From me regarding ReadEntityBodyMode (doesn't actually work,
>>>> just the interface)
>>>>
>>>
>>> Simple, merged.
>>>
>>>
>>>> PR1354 - From me regarding Request.Abort
>>>>
>>>
>>> Simple, merged.
>>>
>>> Miguel.
>>>
>>> _______________________________________________
>>> Mono-devel-list mailing list
>>> Mono-devel-list at lists.ximian.com
>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20141020/e34e377d/attachment-0001.html>