[Mono-dev] Pull Requests

[Martin Thwaites]

Just to give my2cents on this.

I would just like to know that things will get looked at approved at some
point.  I saw a while back that there was a flurry of activity on PR's, and
some people (possibly after direction from Miguel) whacked that list down
considerably.

Is there anything that Xamarin can do to maybe help out with an ETA on
reviewing pull requests? even if it's something along the lines of "This
needs X to review it, and we expect to get time next month".  I know
Xamarin staff aren't the only people who can approve, but maybe that's a
fallback if noone can review it earlier.

As always, love what you do, and as you said the bar is high in mono which
I love.  I'm actually using the mono codebase as an example for my staff to
look at to see how an opensource project can be done right.

Thanks,
Martin

On 16 October 2014 20:39, Greg Young <gregoryyoung1 at gmail.com> wrote:

> Miguel,
>
> "In the meantime, if you need quick hacks, you can always fork Mono
> and distribute your forked version with your changes."
>
> To be fair you know the pain we deal with due to this.
>
> For us if we had a backlog of 200 PRs this would be a wonderful
> problem to have. I would immediately hire 1-2 people to knock it down.
> I think what most people in the community perceive (which is why I
> started the topic) is that outside support is not making it into the
> pipeline.
>
> Cheers,
>
> Greg
>
> ps Miguel did I mention you need to come to Lithuania next year?
>
> On Thu, Oct 16, 2014 at 8:31 PM, Miguel de Icaza <miguel at xamarin.com>
> wrote:
> > Hello Greg,
> >
> > The best approach is to stay engaged in the pull requests and bring the
> > attention to the mailing list for us to discuss.
> >
> > Long term, the ideal situation is one where we can give more people
> commit
> > rights, and review rights.   But until we have developed the skills in
> the
> > community that are needed, we will continue with the current setup.
> >
> > The bar for mono is high: we can not just take any code and distribute
> it,
> > since the impact of mistakes is large.
> >
> > To give an example, even new Xamarin employees that are hired to work
> > exclusively on the runtime are working through pull requests, and they
> also
> > have to wait for some of the more senior people to review and approve the
> > patches.   We have very nice fixes that we still postpone until we have
> the
> > bandwidth of doing a full review.
> >
> > In the meantime, if you need quick hacks, you can always fork Mono and
> > distribute your forked version with your changes.
> >
> > Miguel
> >
> > On Thu, Oct 16, 2014 at 3:27 PM, Greg Young <gregoryyoung1 at gmail.com>
> wrote:
> >>
> >> This topic has been brought up in a ton of other threads I just want
> >> to centralize the topic.
> >>
> >> I have felt the pain many others have discussed (6-12 months for an
> >> accept of PR, we actually had a separate distribution of mono for a
> >> while).
> >>
> >> Is there background on the issue?
> >> What are the issues that are involved from a xamarin perspective?
> >> How can the community help?
> >>
> >> Cheers,
> >>
> >> Greg
> >>
> >> --
> >> Studying for the Turing test
> >> _______________________________________________
> >> Mono-devel-list mailing list
> >> Mono-devel-list at lists.ximian.com
> >> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> >
> >
>
>
>
> --
> Studying for the Turing test
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20141016/32c95e30/attachment-0001.html>