[Mono-dev] Porting System.Numerics from referencesource, approaches for copying code?

[Miguel de Icaza]

Hey Alex,

In general, the approach works.

I am curious as to what is that you had to remove, and why.   Can you
describe the needed changes?   (I saw the diff, but it is hard to tell what
happened with it).

I thought that Numerics was pretty much standalone.

On Sat, Nov 29, 2014 at 10:32 AM, Alexander Köplinger <
alex.koeplinger at outlook.com> wrote:

> Hey, I've been trying to port System.Numerics (BigInteger, Complex
> classes) from referencesource to see and feel what the process looks like.
> It mostly went fine, but there was one file (number.cs) I couldn't
> reference directly from the submodule and had to copy to the assembly folder
> in the Mono tree.
>
> I had to remove a bunch of code from that file to trim it down to only
> what is needed for System.Numerics to compile (all the tests pass now as
> well).
> Question: is this a valid approach or is there something better? Note that
> ifdefing the file wasn't feasible as it originally sits inside corlib and
> has many other unrelated methods in it.
>
> Here's the commit with the WIP:
> https://github.com/akoeplinger/mono/commit/d7c461155a975a35f76b79ebcc3fe33407bd5dce
>
> -- Alex
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20141129/e229fbba/attachment.html>